Development

#8522 (Enhance E_STRICT compatibility)

You must first sign up to be able to contribute.

Ticket #8522 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

Enhance E_STRICT compatibility

Reported by: bschussek Assigned to: fabien
Priority: major Milestone: 1.3.5
Component: other Version: 1.3.x DEV
Keywords: Cc:
Qualification: Unreviewed

Description

Several tests currently throw warning or notice errors. These tests can be detected with the updated version of lime.

  • i18n/sfMessageSource_XLIFFTest
  • util/sfNamespacedParameterHolderTest
  • validator/sfValidatorDateTest
  • view/sfViewCacheManagerTest
  • widget/i18n/sfWidgetFormI18nChoice*
  • widget/i18n/sfWidgetFormI18nSelect*

Furthermore, several unit tests create sfApplicationConfiguration instances. In the initConfiguration() method of this class, the error_reporting level is set to symfony's default level:

E_PARSE | E_COMPILE_ERROR | E_ERROR | E_CORE_ERROR | E_USER_ERROR

This leads to E_STRICT errors being suppressed. When the reporting level is set to E_ALL | E_STRICT, the following additional test throws errors:

  • i18n/sfI18NTest

Attachments

sfI18N.patch (1.4 kB) - added by bschussek on 04/09/10 15:34:11.
This patch fixes the warnings issued by the invalid array_flip() usage in sfI18N.

Change History

04/09/10 15:34:11 changed by bschussek

  • attachment sfI18N.patch added.

This patch fixes the warnings issued by the invalid array_flip() usage in sfI18N.

04/09/10 16:27:41 changed by Kris.Wallsmith

Please let the core team set the ticket milestone.

04/09/10 16:28:00 changed by Kris.Wallsmith

Oops, foot in mouth. Sorry bschussek :)

05/19/10 13:47:11 changed by fabien

(In [29520]) [1.3, 1.4] fixed warnings issued by the invalid array_flip() usage in sfI18N (refs #8522)

05/19/10 13:47:59 changed by fabien

  • status changed from new to closed.
  • resolution set to fixed.

(In [29521]) [1.3, 1.4] fixed E_STRICT compatbility of some unit tests (closes #8522)