Development

#8246 (getFilterForm() does not resemble same pattern as getForm())

You must first sign up to be able to contribute.

Ticket #8246 (closed defect: wontfix)

Opened 1 month ago

Last modified 1 month ago

getFilterForm() does not resemble same pattern as getForm()

Reported by: darrenl Assigned to: fabien
Priority: minor Milestone:
Component: configuration Version: 1.4.1
Keywords: Cc:
Qualification: Unreviewed

Description

In lib/generator/sfModelGeneratorConfiguration.class.php the method getFilterForm() does not resemble the same pattern as getForm(). I have corrected it myself but this is vital if you want to pass custom options to your form filters.

I did so with: 

  public function getFilterForm($filters, $options = array())
  {
    $class = $this->getFilterFormClass();

    return new $class($filters, array_merge($this->getFilterFormOptions(), $options));
  }

  public function getFilterFormOptions()
  {
    return array();
  }

It would be nice to have this built in for future versions.

Thanks, Darren

Change History

02/12/10 13:41:55 changed by Kris.Wallsmith

  • status changed from new to closed.
  • resolution set to wontfix.

Sorry, applying this enhancement would create BC issues.

The Sensio Labs Network

Since 1998, Sensio Labs has been promoting the Open-Source software movement by providing quality web application development, training, consulting.
Sensio Labs also supports several large Open-Source projects.

Open-Source Products

Services

> More