Development

#7503 ((sfDoctrine2Plugin) Wrong default type in sfDoctrineSqlLogger)

You must first sign up to be able to contribute.

Ticket #7503 (closed defect: fixed)

Opened 4 years ago

Last modified 3 years ago

(sfDoctrine2Plugin) Wrong default type in sfDoctrineSqlLogger

Reported by: simonvdd Assigned to: Jonathan.Wage
Priority: minor Milestone:
Component: sfDoctrinePlugin Version: 1.3.0 beta1
Keywords: sfDoctrine2Plugin, Doctrine 2, sfDoctrinePlugin Cc:
Qualification: Unreviewed

Description

In sfDoctrine2Plugin/lib/debug/sfDoctrineSqlLogger, method logSql is declared as follows 

public function logSql($sql, array $params = null)

So when you call it without second argument, it generates an error in the following method fixParams(), in foreach(). Solved with the following declaration: 

public function logSql($sql, array $params = array())

Environment: sfDoctrine2Plugin (currently embedding Doctrine 2.0.0 Alpha 1) used with Symfony 1.3.0 BETA 1 WampServer, Apache 2.2.11, PHP 5.3.0, MySQL 5.1.36

Change History

11/03/09 20:02:46 changed by simonvdd

  • version changed from 1.3 branch to 1.3.0 beta1.

12/01/09 08:07:26 changed by Jonathan.Wage

  • status changed from new to closed.
  • resolution set to fixed.

(In [24642]) [1.4][sfDoctrine2Plugin] Casting array (closes #7503)