Impossible to set default database encoding

I pinpointed the bug to be in sfDoctrineDatabase class, its trying to change value to constant that doesnt exists in doctrine. If you pass just value it works, but dunno why it was done in a first place.

    foreach ($attributes as $name => $value)
    {
      if (is_string($name))
      {
        $stringName = $name;
        $name = constant('Doctrine::ATTR_'.strtoupper($name));
      }
      if (is_string($value))
      {
        $value = constant('Doctrine::'.strtoupper($stringName).'_'.strtoupper($value));
      }
      $this->_doctrineConnection->setAttribute($name, $value);
    }

I propose the following change in order to support charset & collate within sf (that's sfDoctrineDatabase.class.php - l.76 for 1.4RC2)

    foreach ($attributes as $name => $value)
    {
      if (is_string($name))
      {
        $stringName = $name;
        $name = constant('Doctrine_Core::ATTR_'.strtoupper($name));
      }

      if (is_string($value))
      {
        $stringName = strtoupper($stringName);
        $notDoctrine = array('DEFAULT_TABLE_CHARSET', 'DEFAULT_TABLE_COLLATE');
        if (!in_array($stringName, $notDoctrine))
        {
          $value = constant('Doctrine_Core::'.$stringName.'_'.strtoupper($value));
        }
     }

And as a pacth

       if (is_string($value))
       {
-        $value = constant('Doctrine_Core::'.strtoupper($stringName).'_'.strtoupper($value));
-      }
+        $stringName = strtoupper($stringName);
+        $notDoctrine = array('DEFAULT_TABLE_CHARSET', 'DEFAULT_TABLE_COLLATE');
+        if (!in_array($stringName, $notDoctrine))
+        {
+          $value = constant('Doctrine_Core::'.$stringName.'_'.strtoupper($value));
+        }
+     }

I can confirm this bug in 1.3RC2 and 1.4RC2.

Something like :

attributes:
        default_table_charset: utf8

is converted in a constant Doctrine_Core::DEFAULT_TABLE_CHARSET_UTF8 which of course does not exists.

I should be Doctrine_Core::DEFAULT_TABLE_CHARSET = 'UTF8'

That makes "attributes" parameter in database.yml unusable.

Sure, we can define them in ProjectConfiguration? class, but it makes sense to group all doctrine parameters in the same place (that is, database.yml)

#6884 seems to relate the same issue

You are using the wrong syntax, it should be:

all:
  doctrine:
    class: sfDoctrineDatabase
    param:
      dsn: 'mysql:host=localhost;dbname=doctrine'
      username: theq
      password: ********
      encoding: utf8

Of course you can always do it with PHP code which is the ideal and recommended way.

Jonathan:
"You are using the wrong syntax" -> I am not sure if encoding the "encoding" option allow setting the collation (does not seem to me when I look at sfDoctrineConnectionListener plus does not work when testing)

"you can always do it with PHP" -> Of course we can do everything with PHP but we already have to modify database.yml to set the db name, host, ... and some other "supported" attributes so for the sake of consistency it might be good to add the support those two parameters.

If you don't want to fix it I am pretty sure this defect will re-appear sometime soon. So you would have to document it somewhere and that would take more time than fixing this defect. So please re-consider this defect, you have a working fix attached plus an other one here: http://www.prettyscripts.com/post/230266570/symfony-doctrine-build-all-and-table-collation.

The attached fix is not a good one. I will see if I can come up with something better. If you look at the patch you will see it is not a good idea.

Isn't it fixed by http://trac.symfony-project.org/changeset/24598 anyway ?

No, that is a different issue.

Might be for a different issue but fix this one altogether. You might only want to add some functional test to be completely clean.

AFAIR "encoding: utf8" sets only connection encoding. Thats useless for me cos when I use symfony task to build database I get text fields with latin1 encoding. Anyway I confirm that r24598 fix this bug.

theq

Just to note, I am using the following syntax in sf1.4, and it works fine:

all:
  mycon1:
    class:  sfDoctrineDatabase
    param:
      dsn:      mysql:dbname=mydb;host=myhost
      username: myuser
      password: mypassword
      encoding: utf8
      attributes:
        DEFAULT_TABLE_TYPE: INNODB
        DEFAULT_TABLE_CHARSET: utf8
        DEFAULT_TABLE_COLLATE: utf8_general_ci

Cheers Hal

No it doesn't. The table and the connection are in UTF-8 butt the database is still created as latin1. Dirty.

SHOW CREATE DATABASE yourdbname;