Development

#6843 ([PATCH] Test results not TAP friendly)

You must first sign up to be able to contribute.

Ticket #6843 (reopened defect)

Opened 4 years ago

Last modified 4 years ago

[PATCH] Test results not TAP friendly

Reported by: eMerzh Assigned to: fabien
Priority: minor Milestone:
Component: lime Version: 1.4.x DEV
Keywords: Cc:
Qualification: Ready for core team

Description

Hi, i'm trying to reuse the output of the test:unit command of symfony, but lime add a dubious line at the end of the test.

Like :

Looks like everything went fine.

But in tap protocol, it is a unknown output and should not be.

It should normaly start with a #

the modifications for this should not be huge, i'll try to add a patch soon

thanks

Attachments

lime_output.patch (1.1 kB) - added by eMerzh on 07/15/09 10:51:14.
a Quick patch
lime_output_with_tests.patch (14.5 kB) - added by eMerzh on 07/15/09 11:01:48.
The patch with tests added

Change History

07/15/09 10:51:14 changed by eMerzh

  • attachment lime_output.patch added.

a Quick patch

07/15/09 11:01:48 changed by eMerzh

  • attachment lime_output_with_tests.patch added.

The patch with tests added

07/15/09 12:17:49 changed by eMerzh

  • qualification changed from Unreviewed to Ready for core team.
  • summary changed from Add # in test results... to [PATCH] Test results not TAP friendly.

07/16/09 13:12:50 changed by eMerzh

Same with info in sfTestFunctionalBase ...

I don't have time to submit a patch or a solution right now...

i'll try to do it later if it isn't done yet

11/10/09 00:07:17 changed by FabianLange

  • status changed from new to closed.
  • resolution set to fixed.

(In [23736]) [lime] updated lime so that the last line 'looks like you ....' adheres to the TAP spec (http://search.cpan.org/~petdance/TAP-1.00/TAP.pm) and prints a # in front of the line. (closes #6843)

11/10/09 00:19:20 changed by eMerzh

Thanks a lot! Is it possible to impact also the 1.3Branch... i haven't looked at it yet...but think that it's not tap friendly...

11/10/09 00:58:31 changed by FabianLange

(In [23741]) [1.3] updated task tests so that they accept # before 'looks like' (refs #6843)

11/10/09 01:19:03 changed by FabianLange

are you referring to lime2? bernhard will have a look at this

12/02/09 09:03:19 changed by eMerzh

  • status changed from closed to reopened.
  • version changed from 1.2.8 to 1.4.x DEV.
  • resolution deleted.

Please just add a # before info ">" in lime in 1.3/1.4 branch....

like this : 

public function info($message)
{
    echo $this->colorizer->colorize(sprintf('#> %s', $message), 'INFO_BAR')."\n";
}