Development

#6744 (Enhancements to Event Dispatcher documentation)

You must first sign up to be able to contribute.

Ticket #6744 (closed documentation: fixed)

Opened 8 months ago

Last modified 8 months ago

Enhancements to Event Dispatcher documentation

Reported by: pbowyer Assigned to: fabien
Priority: minor Milestone:
Component: event Version: 1.2.7
Keywords: Cc:
Qualification: Unreviewed

Description

Thanks for releasing the event dispatcher. I read through the documentation and spotted some grammatical errors and have attached a patch. I have also tried to clarify, in particular the first two paragraphs which didn't read well.

A couple of points I have not addressed in the patch, as I don't know how to:

  • In the first recipe, it would be useful to give an example of how $this->dispatcher was instantiated - a singleton method somewhere?
  • I don't understand why the first parameter of sfEvent needs to be '$this' - what is its significance and why can't it always be omitted?

Please check changes for factual accuracy - I'm not that familiar (yet!) with event dispatch!

Attachments

01-Event-Dispatcher.markdown.diff (3.6 kB) - added by pbowyer on 07/03/09 18:29:48.

Change History

07/03/09 18:29:48 changed by pbowyer

  • attachment 01-Event-Dispatcher.markdown.diff added.

07/03/09 19:14:58 changed by fabien

  • status changed from new to closed.
  • resolution set to fixed.

(In [19856]) [event_dispatcher] enhancements to Event Dispatcher documentation (closes #6744 - patch from pbowyer)

07/03/09 19:25:25 changed by fabien

(In [19857]) [event_dispatcher] splitted the first chapter to create a new Recipes chapter with one new recipe (refs #6744)

The Sensio Labs Network

Since 1998, Sensio Labs has been promoting the Open-Source software movement by providing quality web application development, training, consulting.
Sensio Labs also supports several large Open-Source projects.