Development

#6695 (Make parameter lime_output optional in lime_test constructor)

You must first sign up to be able to contribute.

Ticket #6695 (closed enhancement: fixed)

Opened 9 months ago

Last modified 9 months ago

Make parameter lime_output optional in lime_test constructor

Reported by: bschussek Assigned to: fabien
Priority: minor Milestone: 1.3.0 alpha1
Component: lime Version: 1.2.7
Keywords: Cc:
Qualification: Unreviewed

Description

Because the parameter $output is in 99% of the cases the same, I'd like to propose to make it optional. It should be lime_output_color() by default, as this seems to be what most of the people are using. 

$t = new lime_test(1);

// instead of

$t = new lime_test(1, new lime_output_color());

Change History

06/25/09 07:52:19 changed by fabien

  • status changed from new to closed.
  • resolution set to fixed.

It has always been the case! With an added since 1.3: the colorization is automatic if the console supports it. I will update the documentation to remove this second argument as few people need to change it as you say.

06/25/09 08:29:48 changed by fabien

  • milestone set to 1.3.0.

Let's be a bit clearer here. The output object argument has always been optional, BUT you needed to use it to be able to have colorization. As of symfony 1.3, there is only one lime_output class that manages automatically the colorization. So, the documentation for 1.2 cannot be changed, but will be for 1.3. I will also changed all the tests of symfony 1.3 to use the new shortcut.

06/25/09 08:35:14 changed by fabien

(In [19531]) [1.3] removed usage of lime_output_color() in unit tests as it is now taken care of automatically by lime (closes #6695)

06/25/09 11:07:07 changed by bschussek

Splendid! Now that's what I call fast ;-)

The Sensio Labs Network

Since 1998, Sensio Labs has been promoting the Open-Source software movement by providing quality web application development, training, consulting.
Sensio Labs also supports several large Open-Source projects.

Open-Source Products

Services

> More