Embedded forms do not call save() or doSave() on the form

This is a really annoying bug... Anyway, there is a little typo in the jonhattan's "patch" :

$form->bind($this->values[$key], $this->taintedValues[$key]);

should be replaced by something like :

$form->bind($this->taintedValues[$key], $this->taintedFiles);

which correspond to the bind() method parameters orders. But it does not resolve the problem of uploading files in embedded forms. See http://stereointeractive.com/blog/2008/12/23/symfony-12-upload-a-file-inside-an-embedded-form/

MUCH better :

$form->bindAndSave($this->taintedValues[$key], $this->taintedFiles, $con);

Hello,

Apparently this patch doesn't fix this issue on my side.

Is there any other solution?

Thanks

I have found something else. If your primary form contains some file inputs (ie. sfWidgetFormInputFile), as $taintedFiles is not an indexed array like $taintedValues, your embedded forms also received the new files fields. That can throw an exception like "Unexpected extra form field named "file".", because your embedded forms does not have file input validators. BUT this exception is silently ignored in the process, and cause the doSave() method of the embedded form to be never called. doSave() is the place where the object relations are handled (1:n, 1:1, n:n) via additionnal methods.

So you can say something like : "if i have a file input in my primary forms, theres is chance that the relations of my embedded forms will not be saved"

The only workaround i found is to add a :

$this->validatorSchema->setOption('allow_extra_fields', true);

to all embedded forms.

Tyx, maybe that's your case ?

For our case we had to use code below. Because in jonhattan's "patch" if there is a Propel/Doctrine based form below a simple sfForm, then this deep embedded form did not receive it's taintedValues. Right values for this embedded forms really is in nested arrays. Maybe someone will find it useful. Took me couple of days to figure it out :)

  public function saveEmbeddedForms($con = null, $forms = null, $taintedValues = null, $taintedFiles = null)
  {
    if (is_null($con))
    {
      $con = $this->getConnection();
    }

    if (is_null($forms))
    {
      $forms = $this->embeddedForms;
    }

    if (is_null($taintedValues))
    {
        $taintedValues = $this->taintedValues;
    }

    if (is_null($taintedFiles))
    {
        $taintedFiles = $this->taintedFiles;
    }

    foreach ($forms as $key => $form)
    {
      if ($form instanceof sfFormPropel)
      {
          $form->bindAndSave($taintedValues[$key], $taintedFiles);
      }
      else
      {
        $this->saveEmbeddedForms($con, $form->getEmbeddedForms(), $taintedValues[$key], $taintedFiles);
      }
    }
  }

You may add the following just before the bind call if you set any CSRF protection

unset($form[self::$CSRFFieldName]);

I'm having the same problem than everyone here.

With latest 1.2.8-dev version (r19193), the embedded forms get saved, but do net receive the ID of the master form, so m2m relations are missing one side.

There is no difference in using the proposed function overrides, or the 1.2.8-dev stock code.

This is what I do to save the M2M relations from and embedded forms:

I make my changes to the updateObject() of the embedded form. It look like this:

The $object is "MusicSong?"

  public function updateObject($values = null)
  {
    $object = parent::updateObject($values);

    if ($values['id'] > 0)
    {
      $c = new Criteria();
      $c->add(MusicSongArtistPeer::SONG, $object->getPrimaryKey());
      MusicSongArtistPeer::doDelete($c);

      $object->setNew(false);
    }
    else
    {
      $object->setNew(true);
    }

    foreach ($values['music_song_artist_list'] as $artistId)
    {
      $obj = new MusicSongArtist();
      $obj->setArtist($artistId);

      $object->addMusicSongArtist($obj);
    }

    return $object;
  }

This is my schema for make you an idea of what is happening:

music_artist:
  id:
  name:       { type: varchar(255) }

music_song:
  id:
  name:         { type: varchar(255) }
  number:       { type: tinyint }

music_song_artist:
  song:              { type: integer, primaryKey: true, required: true, foreignTable: music_song, foreignReference: id, onDelete: cascade }
  artist:            { type: integer, primaryKey: true, required: true, foreignTable: music_artist, foreignReference: id, onDelete: cascade }