Development

#585 ([PATCH] guid in RSS needs isPermalink attribute)

You must first sign up to be able to contribute.

Ticket #585 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

[PATCH] guid in RSS needs isPermalink attribute

Reported by: dd-symfonytrac@davedash.com Assigned to:
Priority: minor Milestone: 0.6.3
Component: Version:
Keywords: Cc:
Qualification:

Description

Without the "isPermalink" attribute for guid in an rss feed, it will be interpreted as true, meaning a guid (e.g. an id of the object in the feed) will be used as the URL for that object.

This is generally not the case. So this patch has isPermalink=false.

This probably can be improved on to make it a setable feature, but forcing it to off makes sense if we have links elsewhere for an item.

Index: sfRss201rev2Feed.class.php
===================================================================
--- sfRss201rev2Feed.class.php  (revision 1328)
+++ sfRss201rev2Feed.class.php  (working copy)
@@ -33,7 +33,7 @@
       $xml[] = '  <link>'.$this->getItemFeedLink($item).'</link>';
       if ($this->getItemFeedUniqueId($item))
       {
-        $xml[] = '  <guid>'.$this->getItemFeedUniqueId($item).'</guid>';
+        $xml[] = '  <guid isPermalink="false">'.$this->getItemFeedUniqueId($item).'</guid>';
       }
                             

Change History

06/09/06 15:18:31 changed by fabien

  • status changed from new to closed.
  • resolution set to fixed.
  • milestone set to 0.6.3.

in r1409

The Sensio Labs Network

Since 1998, Sensio Labs has been promoting the Open-Source software movement by providing quality web application development, training, consulting.
Sensio Labs also supports several large Open-Source projects.