Development

#5163 ([PATCH] make plugin:publish-assets work properly with plugins setup by setPluginPath())

You must first sign up to be able to contribute.

Ticket #5163 (closed defect: fixed)

Opened 7 months ago

Last modified 7 months ago

[PATCH] make plugin:publish-assets work properly with plugins setup by setPluginPath()

Reported by: mahono Assigned to: fabien
Priority: major Milestone: 1.2.1
Component: tasks Version: 1.2.0
Keywords: plugin:publish-assets Cc:
Qualification: Unreviewed

Description

When using a plugin by setPluginPath() the current implementation of plugin:publish-assets task is not able to setup web directories properly.

For example I have checked out the ysfYUIPlugin somewhere on my disk and when I set the plugin: 

$this->setPluginPath('ysfYUIPlugin', '/path/to/ysfYUIPlugin/branches/1.2');

The task thinks that the plugin name is '1.2' which is obviously wrong.

The patch fixes that issue.

Attachments

ticket5163.diff (1.8 kB) - added by mahono on 12/03/08 15:55:30.

Change History

12/03/08 15:55:30 changed by mahono

  • attachment ticket5163.diff added.

12/03/08 16:12:28 changed by mahono

A cleaner solution might be to add a method to sfProjectConfiguration that returns the enabled plugins in the form of a name => path array.

12/10/08 23:06:40 changed by FabianLange

  • status changed from new to closed.
  • resolution set to fixed.

(In [13929]) [1.2] publish-assets now works correctly for all active plugins, even when they set the plugin path to a different directory. fixes #5163. refs #4926

The Sensio Labs Network

Since 1998, Sensio Labs has been promoting the Open-Source software movement by providing quality web application development, training, consulting, and supporting several large Open-Source projects.

Open-Source Software

Services

> More