Development

#5140 ([PATCH] Admin Generation : loadConfiguration wrong paths)

You must first sign up to be able to contribute.

Ticket #5140 (closed defect: fixed)

Opened 7 months ago

Last modified 7 months ago

[PATCH] Admin Generation : loadConfiguration wrong paths

Reported by: DigitalBase Assigned to: fabien
Priority: major Milestone: 1.2.1
Component: generator Version: 1.2.0
Keywords: Cc: gijs@digitalbase.eu
Qualification: Ready for core team

Description

sfModelGenerator on line 394: 

$moduleDirs = array_keys($config->getControllerDirs($this->getModuleName()));
    if (is_file($moduleDirs[0].'/../lib/configuration.php'))
    {
      require_once $moduleDirs[0].'/../lib/configuration.php';
      $class = $this->getModuleName().'GeneratorConfiguration';
    }
    else
    {
      $class = 'Base'.ucfirst($this->getModuleName()).'GeneratorConfiguration';
    }

loadconfiguration only checks in $moduleDirs[0]. If you have admin generated modules in a plugin this will not be loaded as this is in $moduleDirs[1].

Attachments

sfModelGenerator.patch (1.4 kB) - added by DigitalBase on 12/02/08 15:25:29.
patch
sfModelGenerator2.patch (1.3 kB) - added by DigitalBase on 12/02/08 15:33:32.
better patch ( a little nicer )

Change History

12/02/08 14:14:26 changed by DigitalBase

related to #5137

12/02/08 14:18:40 changed by DigitalBase

  • cc set to gijs@digitalbase.eu.

12/02/08 15:25:29 changed by DigitalBase

  • attachment sfModelGenerator.patch added.

patch

12/02/08 15:26:09 changed by DigitalBase

  • qualification changed from Unreviewed to Ready for core team.
  • summary changed from Admin Generation : loadConfiguration wrong paths to [PATCH] Admin Generation : loadConfiguration wrong paths.

12/02/08 15:33:32 changed by DigitalBase

  • attachment sfModelGenerator2.patch added.

better patch ( a little nicer )

12/11/08 15:15:32 changed by fabien

  • status changed from new to closed.
  • resolution set to fixed.

(In [13947]) [1.2] fixed admin generator configuration file loading (closes #5137, #5140)

The Sensio Labs Network

Since 1998, Sensio Labs has been promoting the Open-Source software movement by providing quality web application development, training, consulting, and supporting several large Open-Source projects.

Open-Source Software

Services

> More