Development

#5074 (Method getMessageSource() of sf18N class calls old method getI18NGlobalDirs() of sfApplicationConfiguration class)

You must first sign up to be able to contribute.

Ticket #5074 (closed defect: fixed)

Opened 7 months ago

Last modified 7 months ago

Method getMessageSource() of sf18N class calls old method getI18NGlobalDirs() of sfApplicationConfiguration class

Reported by: Valgard Assigned to: fabien
Priority: major Milestone: 1.1.7
Component: i18n Version: 1.1.6
Keywords: i18n, getMessageSource, getI18NGlobalDirs, getDecoratorDirsGlobalDirs Cc: tommyd, klemens_u
Qualification: Unreviewed

Description

The class sf18N calls the old class method getI18NGlobalDirs() of sfApplicationConfiguration in the method getMessageSource(). It should call the new method getDecoratorDirsGlobalDirs().

Change History

11/25/08 17:30:23 changed by Valgard

Suggested patch: 

Index: lib/i18n/sfI18N.class.php
===================================================================
--- lib/i18n/sfI18N.class.php	(Revision 13175)
+++ lib/i18n/sfI18N.class.php	(Arbeitskopie)
@@ -185,7 +185,7 @@
   {
     if (!isset($this->messageSource))
     {
-      $dirs = ($this->isMessageSourceFileBased($this->options['source'])) ? $this->configuration->getI18NGlobalDirs() : null;
+      $dirs = ($this->isMessageSourceFileBased($this->options['source'])) ? $this->configuration->getDecoratorDirsGlobalDirs() : null;
       $this->setMessageSource($dirs, $this->culture);
     }

11/27/08 08:38:21 changed by fabien

  • status changed from new to closed.
  • resolution set to fixed.

(In [13383]) [1.1] fixed typo introduced in r13124 (closes #5074)

12/02/08 16:59:07 changed by Valgard

  • status changed from closed to reopened.
  • version changed from 1.1.5 to 1.1.6.
  • resolution deleted.
  • milestone changed from 1.1.6 to 1.1.7.

The class sf18N still calls the old class method getI18NGlobalDirs(), but the function name is now getI18NDirsGlobalDirs()

Suggested patch: 

Index: lib/config/sfApplicationConfiguration.class.php
===================================================================
--- lib/config/sfApplicationConfiguration.class.php	(Revision 13636)
+++ lib/config/sfApplicationConfiguration.class.php	(Arbeitskopie)
@@ -403,7 +403,7 @@
    *
    * @return array An array of i18n directories
    */
-  public function getI18NDirsGlobalDirs()
+  public function getI18NGlobalDirs()
   {
     $dirs = array();

12/02/08 17:27:02 changed by tommyd

  • cc set to tommyd.

Added me to CC, I just got bitten by this bug after I've updated to 1.1.6.

12/20/08 11:16:14 changed by klemens_u

  • cc changed from tommyd to tommyd, klemens_u.

I've this problem as well with 1.1.7-DEV. A quick fix would be appreciated a lot!

Thanks, Klemens

12/20/08 12:04:56 changed by fabien

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [14219]) [1.1] fixed typo (closes #5074)

The Sensio Labs Network

Since 1998, Sensio Labs has been promoting the Open-Source software movement by providing quality web application development, training, consulting, and supporting several large Open-Source projects.

Open-Source Software

Services

> More