Development

#5044 (Top level admin generator should be ORM-independent)

You must first sign up to be able to contribute.

Ticket #5044 (new enhancement)

Opened 7 months ago

Last modified 7 months ago

Top level admin generator should be ORM-independent

Reported by: GaryFx Assigned to: fabien
Priority: major Milestone: 1.3.0
Component: generator Version: 1.2.0 BETA2
Keywords: Cc:
Qualification: Unreviewed

Description

The top level admin-generator task really has no database/ORM-specific duties. Currently, the two implementations, sfPropelGenerateAdminTask and sfDoctrineGenerateAdminTask are essentially clones of each other, with just some values changed. The latter had to be created manually, with the result that the two admin generators were inconsistent in 1.2.0 Beta 2.

I've attached a first crack at an ORM-independent admin generator task. The only thing this doesn't do is check that the model class is a subclass of the appropriate ORM base class for models. That's because the naming of those base classes is inconsistent, and it's not clear that it's worth creating a separate mechanism to handle it.

If this is added, it belongs in the symfony lib/task/generator directory, while the corresponding files in the Propel and Doctrine plugins should be removed, and the documentation updated.

Attachments

sfGenerateAdminTask.class.php (5.9 kB) - added by GaryFx on 11/23/08 17:27:51.
New task class file

Change History

11/23/08 17:27:51 changed by GaryFx

  • attachment sfGenerateAdminTask.class.php added.

New task class file

11/23/08 18:31:25 changed by FabianLange

  • milestone changed from 1.2.0 to 1.3.0.

Thanks, but this wont make it for 1.2 - setting for 1.3

The Sensio Labs Network

Since 1998, Sensio Labs has been promoting the Open-Source software movement by providing quality web application development, training, consulting, and supporting several large Open-Source projects.