Development

#5039 (sfValidatorDate uses the wrong format when displaying an error)

You must first sign up to be able to contribute.

Ticket #5039 (closed defect: fixed)

Opened 7 months ago

Last modified 7 months ago

sfValidatorDate uses the wrong format when displaying an error

Reported by: jeremy Assigned to: fabien
Priority: minor Milestone: 1.2.0 RC2
Component: validation Version: 1.2.0 BETA2
Keywords: sfValidatorDate, date_format, date_format_range_error Cc:
Qualification: Unreviewed

Description

The documentation on / sfValidatorDate states that the default format for date_format_range_error is m/d/Y H:i:s. However, it is actually 'd/m'/Y H:i:s.

I'm not sure if this is a bug in the documentation or source code, but it's a trivial fix either way.

Attachments

sfValidatorDate.class.php.diff (142 bytes) - added by jeremy on 11/23/08 05:11:53.

Change History

11/23/08 05:11:53 changed by jeremy

  • attachment sfValidatorDate.class.php.diff added.

11/23/08 05:13:13 changed by jeremy

Can someone tell me if I done good? I've never submitted a patch before (for anything... hell, I've never even used "diff" before), so even though this is pretty much the easiest fix ever, I'd like to make sure I did it right so I can (hopefully) do bigger ones in the future.

11/23/08 11:11:24 changed by FabianLange

jeremy, everything is allright. But your ticket was also good enough to fix without patch :-) I dont know which is correct, doc or impl. i would guess impl is right and doc needs to be fixed. Fabien knows for sure :-)

11/23/08 16:04:19 changed by FabianLange

  • status changed from new to closed.
  • resolution set to fixed.

(In [13277]) [1.1] fixed PHPDoc on sfValidatorDate. fixes #5039

11/23/08 16:04:25 changed by FabianLange

(In [13278]) [1.2] fixed PHPDoc on sfValidatorDate. fixes #5039

The Sensio Labs Network

Since 1998, Sensio Labs has been promoting the Open-Source software movement by providing quality web application development, training, consulting, and supporting several large Open-Source projects.

Open-Source Software

Services

> More