Development

#4973 ([PATCH] Add possibility to specify type of virtual fields in admin generator)

You must first sign up to be able to contribute.

Ticket #4973 (closed enhancement: fixed)

Opened 8 months ago

Last modified 7 months ago

[PATCH] Add possibility to specify type of virtual fields in admin generator

Reported by: peper Assigned to: FabianLange
Priority: minor Milestone: 1.2.0 RC2
Component: model Version:
Keywords: Cc:
Qualification: Accepted

Description

Hello,

I propose making the type of virtual fields be configurable instead of forcing it to be 'Text'. This is a simple change in sfModelGeneratorConfiguration. Patch follows.

P.S. I have removed isset($config['default'][$field]) ? $config['default'][$field] : array(), cause it's not set for virtual fields anyway afaics - http://trac.symfony-project.org/browser/plugins/sfPropelPlugin/trunk/data/generator/sfPropelModule/admin/parts/fieldsConfiguration.php#L67

Attachments

virtual_fields_type.patch (0.8 kB) - added by peper on 11/17/08 20:24:29.

Change History

11/17/08 20:24:29 changed by peper

  • attachment virtual_fields_type.patch added.

11/22/08 15:34:38 changed by FabianLange

  • milestone set to 1.2.0 RC2.

11/23/08 19:09:34 changed by FabianLange

  • owner changed from fabien to FabianLange.
  • status changed from new to assigned.
  • qualification changed from Unreviewed to Accepted.

11/23/08 19:15:40 changed by FabianLange

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [13281]) [1.2] made type of virtual fields configurable in generators. fixes #4973

11/23/08 19:16:24 changed by FabianLange

peper as far as i see doctrine sets defaults for this, so i chose not to remove the line, however i moved the type so you can override it in the config

The Sensio Labs Network

Since 1998, Sensio Labs has been promoting the Open-Source software movement by providing quality web application development, training, consulting, and supporting several large Open-Source projects.