sfPropelPager, Criteria with addGroupByColumn, gives pager the wrong count for total and pages

(In [1654]) (fixes #487), fabien please review original purpose of clearGroupByColumns

(fixed in [1654])

(In [1677]) fixed sfPropelPager, Criteria with addGroupByColumn, gives pager the wrong count for total and pages (closes #487 - patch from synace)

see http://www.symfony-project.com/forum/index.php?t=rview&goto=10731&th=2450#msg_10731

(In [1758]) reverted r1677 (closes #487)

Why was reverted? This line still makes the pager to be wrong

Hi, this is a major issue for me as well. Is this going to be fixed? Why couldn't we just remove the line as was suggested by synace?

In the first post of this thread http://www.symfony-project.org/forum/index.php?t=rview&goto=10731&th=2450#msg_10731 vonLeeb said "But gouping is needed in parent<->children relationship when you want to count children of each of your parent records and present it." What does this mean?

Regards Joe Thong

Had this problem. Fixed by changing '$distinct = false' to '$distinct = true' overriding the doCount() function in the peer class.

David Lefkon

May also be necessary (e.g. if not joining other tables) to override the default count_distinct column in the peer class:

const COUNT_DISTINCT = 'COUNT(DISTINCT lead.CODE)';

where 'lead' is the class and 'CODE' is the field name that want to group by.

This is really a bug. Since BasePeer::doCount method checks if criteria has groub by columns and able to perform correct count under this circumstances - the clearGroupByColumns is not needed here. May be somebody from core team can accept this as a bug? I don't think it'll be a problem for anyone to prepare patch.

I'm still seeing this in 1.2.5, any particular reason this is still not fixed 3 years after opening? This makes the pager pretty useless for situations where we have complex queries.

Is this blocked on a bug upstream in Propel itself? If so, can we get a bug number in their tracker here so we can follow up on that?

I agree that this is a bug.

The solution would be just to remove line 43

public function init() {

$hasMaxRecordLimit = ($this->getMaxRecordLimit() !== false); $maxRecordLimit = $this->getMaxRecordLimit();

$cForCount = clone $this->getCriteria(); $cForCount->setOffset(0); $cForCount->setLimit(0);

// $cForCount->clearGroupByColumns();

$count = call_user_func(array($this->getClassPeer(), $this->getPeerCountMethod()), $cForCount);