Development

#4514 (Cache debug html code is cached when "with_layout" is enabled)

You must first sign up to be able to contribute.

Ticket #4514 (closed defect: fixed)

Opened 9 months ago

Last modified 8 months ago

Cache debug html code is cached when "with_layout" is enabled

Reported by: nicolas Assigned to: fabien
Priority: minor Milestone: 1.1.5
Component: cache Version: 1.1.2
Keywords: debug staging Cc:
Qualification: Unreviewed

Description (Last modified by nicolas)

If you create a "staging" environment in an application with this settings:

staging:
  .settings:
    cache:                  on
    web_debug:              on

And configure the cache for a basic index action including the layout, like this:

index:
  enabled:     on
  with_layout: true

Then the cached template will contains each time the debug-related html code (see the attached cache.sample.txt file)

Attachments

cache.sample.txt (10.9 kB) - added by nicolas on 09/28/08 18:54:04.
Sample cached template from a staging environment
Image 6.png (61.4 kB) - added by nicolas on 09/28/08 18:54:48.
Sample browser rendering of the problem
sfCacheFilter.class.php.diff (0.8 kB) - added by phuson on 11/07/08 22:06:43.
Patch

Change History

09/28/08 18:54:04 changed by nicolas

  • attachment cache.sample.txt added.

Sample cached template from a staging environment

09/28/08 18:54:48 changed by nicolas

  • attachment Image 6.png added.

Sample browser rendering of the problem

09/28/08 18:56:36 changed by nicolas

  • description changed.
  • summary changed from Cache debug html is cached to Cache debug html code is cached when "with_layout" is enabled.

09/29/08 15:33:13 changed by nicolas

  • milestone changed from 1.1.3 to 1.1.4.

10/03/08 21:51:14 changed by fabien

  • milestone changed from 1.1.4 to 1.1.5.

11/07/08 22:01:42 changed by phuson

Attached is my patch for this bug.

Fabien, please let me know if I can check it in or if it's breaking something else that I didn't account for.

11/07/08 22:06:43 changed by phuson

  • attachment sfCacheFilter.class.php.diff added.

Patch

11/18/08 12:14:40 changed by nicolas

  • status changed from new to closed.
  • resolution set to fixed.

(In [13122]) [1.1] fixed weird cache with layout bug - patch by phuson (closes #4514)

11/18/08 12:17:36 changed by nicolas

(In [13123]) [1.2] fixed weird cache with layout bug - patch by phuson (refs #4514)

The Sensio Labs Network

Since 1998, Sensio Labs has been promoting the Open-Source software movement by providing quality web application development, training, consulting, and supporting several large Open-Source projects.