Development

#4400 ([sfDoctrinePlugin] foreign keys don't appear as dropdown if the column name is ised instead of the field name)

You must first sign up to be able to contribute.

Ticket #4400 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

[sfDoctrinePlugin] foreign keys don't appear as dropdown if the column name is ised instead of the field name

Reported by: francois Assigned to: Jonathan.Wage
Priority: minor Milestone:
Component: sfDoctrinePlugin Version: 1.0.18
Keywords: Cc:
Qualification: Unreviewed

Description

The Propel admin generator accepts column names for foreign key columns, and will display a dropdown list control to edit them. 

// in generator.yml
edit:
  display: [article_id, body]

The Doctrine generator, on the other hand, won't display a dropdown list unless the relation name is used in the generator.yml. 

edit:
  display: [Article, body]

When passed with the foreign key column name instead of the relation name, the Doctrine admin generator uses a simple text input control.

I think that for the sake of consistency between the two ORMs, the Doctrine admin generator should display a dropdown list when a foreign key column name is used.

Patch is attached to provide this feature.

Attachments

sfDoctrineAdminGenerator.patch (1.3 kB) - added by francois on 09/17/08 17:19:26.

Change History

09/17/08 17:19:26 changed by francois

  • attachment sfDoctrineAdminGenerator.patch added.

09/21/08 16:29:23 changed by Jonathan.Wage

  • status changed from new to closed.
  • resolution set to fixed.

(In [11703]) [1.0, 1.1, 1.2] fixes #4400

09/21/08 18:57:23 changed by francois

I see a fix in the 0.1 branch, but not in the 1.0... What is this 0.1 branch for?

09/21/08 19:04:28 changed by Jonathan.Wage

(In [11707]) [1.0] fixes #4400 again

09/21/08 19:05:26 changed by Jonathan.Wage

Sorry about that, I committed it to all branches(or tried to) and the 1.0 branch didn't commit. I did it individually. Thanks for the patch.