range() should not be used to specify years range in sfWidgetFormDate

Can you be a bit more explicit, I don't understand clearly the problem you describe. Can you provide an example? Thanks.

Okay, with the lack of explanations, I flag this one as invalid. Feel free to reopen it if you can provide more details.

Just to expand on this (for the benefit of anyone finding it while googling more than anything) as I ran across the issue myself today, if you have a sfWidgetFormDate field, and you want to specify the 'years' which can be selected, the immediate thought that springs to mind is to use the range() function: new sfWidgetFormDate(array('years' => range(1920,2000));

However the array range() builds has keys incrementing from 0, so is useless, and causes an 'invalid' verification error.

One way around it is to create a variable of your own with keys and values for the years, then pass it as the 'year' option, like the below.

$years = range(1920, 2000); //Creates array of years between 1920-2000 $years_list = array_combine($years, $years); //Creates new array where key and value are both values from $years list

new sfWidgetFormDate(array('years' => $years_list));

Perhaps symfony could offer a way of automating this with 'year_min' and 'year_max' options for sfWidgetDormDate ?

Just came across this issue myself today.

The constructor provides the PHPdoc message:

* * years: An array of years for the year select tag (optional)

This led me to believe this would be a straight array, in the format: array(1998, 1999, 2000, 2001)

In-fact, the array needs to be key => value: array(1998 => '1998', 1999 => '1999', 2000 => '2000', 2001 => '2001', 2002 => '2002')

Using array_combine() also works.

Changing the documentation to show something along the lines of "... as $key => $value" would help avoid this confusion.

[PATCH] Improve sfWidgetFormDate constructor documentation

The forms book appendix A describes how to do it quite clearly. I will also add a note in the PHPDoc API.

in r16259