Confirm popup make javascript call don't work with IE

Replying to Leonard:

While using a remote_function, link_to_function, link_to remote or any function that uses a 'confirm' option, the call don't work on IE6 and IE7 the generated code is

"... onClick="if(confirm('Confirmation message'){..."

whereas it should be

"... onClick="if(window.confirm('Confirmation message'){..."

PATCH

File : php5\PEAR\symfony\helper\JavascriptHelper?.php

line 94 is :

$html_options['onclick'] = "if(confirm('$confirm')){ $function;}; return false;";

line 94 should be :

$html_options['onclick'] = "if(window.confirm('$confirm')){ $function;}; return false;";

line 482 is :

$function = "if(confirm('".escape_javascript($options['confirm'])."')) { $function; }";

line 482 should be :

$function = "if(window.confirm('".escape_javascript($options['confirm'])."')) { $function; }";

Is this fixed? or is just ready for review?

I don't know. I've only posted the ticket and proposed a fix because I thaught this would interest other symfony users.

I don't know if the Symfony team have taken this into account.

adding the window namespace explicitly should do no harm. imho we can apply this for 1.x

Why is this fix in 1.2.5 still not applied? Would really help me... and probably also others who have to fight with IE6.

(In [17383]) [1.3] fixed confirm dialog does not work in ie6 (closes #4152)

(In [17384]) [1.2] fixed confirm dialog does not work in ie6 (closes #4152)

(In [17385]) [1.1] fixed confirm dialog does not work in ie6 (closes #4152)

(In [17386]) [1.0] fixed confirm dialog does not work in ie6 (closes #4152)

Shouldn't this patch also be applied to source:/branches/1.2/lib/helper/JavascriptBaseHelper.php@trunk#L47 in order to fix link_to_function()? The patch in [17384] only fixes it for remote_function()

window.confirm is a band-aid... the real problem is that link_to_function adds the onClick attribute but does not remove confirm from html_options. As a result, a confirm attribute shows up in the 'a' tag.

This has two problems:

1. There's no such attribute, it's invalid HTML. 2. In IE, the current tag is the first context in which a property matching a method name without an explicit object is looked for. When it finds the 'confirm' attribute and sees that it is not a method, it knows it can't execute it, and generates the error.

The correct fix in link_to_function:

if ( isset($html_optionsconfirm?) )

{

$confirm = escape_javascript($html_optionsconfirm?); $html_optionsonclick? = "if(confirm('$confirm')){ $function;}; return false;"; // tom@punkave.com: without this we break IE, // and produce invalid HTML in any case unset($html_optionsconfirm?);

}

Let's see if I can format that code better with wikiformatting:

if ( isset($html_options['confirm']) )
    {
      $confirm = escape_javascript($html_options['confirm']);
      $html_options['onclick'] = "if(confirm('$confirm')){ $function;}; return false;";
      unset($html_options['confirm']);
    }

oh how could we miss that unset there.

(In [20870]) [1.2, 1.3] fixed invalid confirm attribute in html showing up by not unseeting the confirm attribute passed into javascript functions. (fixes #4152)