Development

#4103 (sfPDOSessionStorage has improper param binding order in session id update query)

You must first sign up to be able to contribute.

Ticket #4103 (closed defect: fixed)

Opened 5 months ago

Last modified 5 months ago

sfPDOSessionStorage has improper param binding order in session id update query

Reported by: warhammerkid Assigned to: fabien
Priority: major Milestone: 1.1.1
Component: other Version: 1.1.0 DEV
Keywords: Cc:
Qualification: Unreviewed

Description

In the updateSessionId method of sfPDOSessionStorage, the query performed does an update of the new id to the current id, which will of course never work. Changing the order the parameter binding fixes this.

$stmt->bindParam(1, $currentId, PDO::PARAM_STR);
$stmt->bindParam(2, $newId, PDO::PARAM_STR);

Should be: 

$stmt->bindParam(1, $newId, PDO::PARAM_STR);
$stmt->bindParam(2, $currentId, PDO::PARAM_STR);

Change History

07/31/08 08:05:38 changed by nicolas

  • status changed from new to closed.
  • resolution set to fixed.

(In [10530]) [1.1] fixes #4103 - sfPDOSessionStorage has improper param binding order in session id update query

07/31/08 08:06:49 changed by nicolas

(In [10531]) [1.2] backport of r10530 - fixes #4103 - sfPDOSessionStorage has improper param binding order in session id update query