Development

#3945 (sfCurlAdapter sends parameters incorrectly)

You must first sign up to be able to contribute.

Ticket #3945 (closed defect: invalid)

Opened 2 years ago

Last modified 2 years ago

sfCurlAdapter sends parameters incorrectly

Reported by: Stefan.Koopmanschap Assigned to: francois
Priority: minor Milestone: plugins
Component: sfWebBrowserPlugin Version: 1.0.17
Keywords: curl, http_build_query Cc:
Qualification: Unreviewed

Description

While working on implementing calls to the Zemanta API I found a problem with the sfCurlAdapter's encoding of POST parameters. I noticed that in Zend Framework using the Zend_Http_Client I got it to work quickly, but using sfWebBrowserPlugin this wasn't the case, so I started digging. I ended up finding the problem in sfCurlAdapter, specifically in the call to http_build_query().

I am unsure of the consequences in other calls to sfCurlAdapter::call(), but would not expect big problems to occur.

Patch attached, should not be too hard to implement ;)

Attachments

sfCurlAdapter_diff.txt (190 bytes) - added by Stefan.Koopmanschap on 07/09/08 00:07:39.
diff of fix

Change History

07/09/08 00:07:39 changed by Stefan.Koopmanschap

  • attachment sfCurlAdapter_diff.txt added.

diff of fix

07/09/08 09:51:59 changed by francois

isn't this a duplicate of #2632? Thanks for the patch anyway.

07/09/08 09:56:45 changed by Stefan.Koopmanschap

Ah, you are right, this is a duplicate, sorry for that.

07/10/08 09:32:49 changed by francois

  • status changed from new to closed.
  • resolution set to invalid.

Could it be that you are working on an older version of the plugin? This was fixed three months ago.

http://trac.symfony-project.org/changeset/8592/plugins/sfWebBrowserPlugin/lib/sfCurlAdapter.class.php

Feel free to reopen the ticket if your problem is not solved.

07/10/08 09:35:55 changed by francois

oops, that's even older than that:

http://trac.symfony-project.org/changeset/4697/plugins/sfWebBrowserPlugin/lib/sfCurlAdapter.class.php

The Sensio Labs Network

Since 1998, Sensio Labs has been promoting the Open-Source software movement by providing quality web application development, training, consulting.
Sensio Labs also supports several large Open-Source projects.

Open-Source Products

Services

> More