Development

#3615 (Add full merge-key support)

You must first sign up to be able to contribute.

Ticket #3615 (closed enhancement: fixed)

Opened 5 years ago

Last modified 5 years ago

Add full merge-key support

Reported by: lsmith Assigned to: fabien
Priority: minor Milestone: 1.2.0
Component: other Version: 1.1.0 RC1
Keywords: Cc:
Qualification: Ready for core team

Description

As I stated on the list, I worked together with a co-worker on adding full merge key support (http://yaml.org/type/merge.html) for sfYaml. It took a bit more code than I expected, but the added overhead when not using this feature does not seem too bad (though I did not benchmark it).

Attachments

sfYamlParser.class.php.diff (3.6 kB) - added by lsmith on 05/22/08 23:38:50.
patch for completing full merge-key support
sfMergeKey.yml.diff (1.2 kB) - added by lsmith on 05/22/08 23:40:41.
patch to update fixtures for additional merge-key features

Change History

05/22/08 23:38:50 changed by lsmith

  • attachment sfYamlParser.class.php.diff added.

patch for completing full merge-key support

05/22/08 23:40:41 changed by lsmith

  • attachment sfMergeKey.yml.diff added.

patch to update fixtures for additional merge-key features

05/27/08 10:36:36 changed by dwhittle

Can we add this for 1.1.0rc2? This is bc with tests..

06/23/08 05:52:32 changed by dwhittle

  • qualification changed from Unreviewed to Ready for core team.
  • milestone changed from 1.2.0 to 1.1.0 FINAL.

This is implemented in dwhittle branch in r9769.

06/23/08 08:56:30 changed by fabien

  • milestone changed from 1.1.0 FINAL to 1.2.0.

08/13/08 09:46:09 changed by fabien

  • status changed from new to closed.
  • resolution set to fixed.

(In [10832]) [1.2] added full merge key support (closes #3615 - patch from lsmith)