[PATCH] Custom checkbox fields unhandled if unchecked in admin generator

I have the same problem on Symfony v1.0.11

I use Symfony on a PostGreSQL Database

Same on v1.0.13...

Same here in v1.0.16. The problem appears to be in the generator's action theme : The expected data type can only be read from the schema, making it impossible to be handled correctly as boolean, see symfony_data_dir/generator/sfPropelAdmin/default/template/actions/action.class.php (@line 200) :

$type = $column->getCreoleType();

That appears to be NULL for a custom field (not defined as boolean in the schema) causing the corresponding update code in the action to look like this :

    if (isset($yourObject['your_custom_boolean_field']))
    {
      $this->yourObject->setYourCustomBooleanField($yourObject['your_custom_boolean_field']);
    }

This is wrong in our case, because if your checkbox is unchecked then it will not be updated because the parameter key is not set in the request.

In my case I really don't want to define that field in the schema, since it belongs to an external table. I suggest that means a new parameter shoud be added to the generator fields to override the way a data field is handled in the action class directly from generator.yml.

Quick patch adapting data handling for boolean value if type not retrieved from the schema AND if the field type is "checkbox_tag"

The above patch will work if your symfony data dir is named sfdata. Please change the base symfony data directory if that's not the case for you.

Same in v1.0.17, patch doesn't help, i've add this line and rename /data dir to /sfdata,

Won't be fixed for sf 1.0 and 1.1, as this requires a lot of internal modifications to the way the generator works. This is fixed in symfony 1.2.