Development

#2795 (Problems with CVS Base directories)

You must first sign up to be able to contribute.

Ticket #2795 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

Problems with CVS Base directories

Reported by: dcondevigo Assigned to: fabien
Priority: minor Milestone: 1.0.14
Component: other Version: 1.0.10
Keywords: Cc:
Qualification: Unreviewed

Description

When you work under CVS, and you modify symfony libraries, there are some parts of the code that doesn't exclude the "CVS/Base" directories from the autoloading feature, and this throws "Cannot redeclare" PHP fatal errors.

In data/bin/symfony.php change the line 165:

$tasks = pakeFinder::type('file')->name($name)->in($dirs);

for:

$tasks = pakeFinder::type('file')->name($name)->ignore_version_control()->in($dirs);

In lib/generator/sfCrudGenerator change the lines 89-90:

$templateFiles = sfFinder::type('file')->name('*.php')->relative()->in($themeDir.'/templates'); $configFiles = sfFinder::type('file')->name('*.yml')->relative()->in($themeDir.'/config');

for:

$templateFiles = sfFinder::type('file')->ignore_version_control()->name('*.php')->relative()->in($themeDir.'/templates'); $configFiles = sfFinder::type('file')->ignore_version_control()->name('*.yml')->relative()->in($themeDir.'/config');

Change History

03/28/08 15:20:04 changed by fabien

  • milestone set to 1.0.13.

03/29/08 09:03:07 changed by fabien

in r8148 for symfony 1.1

for symfony 1.0, I think there are a lot more occurences where a finder needs/can exclude version control directories. Not sure if we want to make the change in the 1.0 branch for every call to a finder.

04/01/08 17:36:14 changed by gregoire

  • milestone changed from 1.0.13 to 1.0.14.

04/04/08 14:25:17 changed by noel

  • status changed from new to closed.
  • resolution set to fixed.

(In [8282]) fixed autoloading with CVS (closes #2795)

04/04/08 17:49:08 changed by Markus.Staab

I think this commit was not needed because the finder does the ingnore_version_control() by defaul since last week?

04/04/08 17:59:46 changed by fabien

sfFinder does ignore_version_control() by default in sf 1.1, not 1.0.

The Sensio Labs Network

Since 1998, Sensio Labs has been promoting the Open-Source software movement by providing quality web application development, training, consulting.
Sensio Labs also supports several large Open-Source projects.