symfony should workaround spyc's "undefined index" warning when parsing malformed yaml files

patch with isset check

I think I have the same problem:

error messages:

(4 times) Notice: Undefined index: in /usr/share/php5/PEAR/symfony/util/Spyc.class.php on line 203
(4 times) Notice: Undefined offset: 0 in /usr/share/php5/PEAR/symfony/util/Spyc.class.php on line 923

I use symfony 1.0.10 and my page ist generated with admin generator and has a edit.yml-Validator-File.

If I reload the page, the error messages disappear.

sorry, my fault: I forgot ":" at the end of my fieldname, in my edit.yml file. I fixed my edit.yml and the error message does not appear anymore.

anyway, its not change on the fact, that on the reported lines is a error. it's a very simple bugfix, if u trust me, i can also fix this bug, and close this ticket. (i have alreade svn-account)

Wouldn't it be better to throw an exception that the configuration is malformed?

Yes of course, it would be. anyway, first of all we need to patch spyc, to close php notice messages. Than it would be very nice, if spyc first validate yml-file and throw Exception on malformed file. or anybody got a better idea?

If someone can come up with a YAML validation tool, it would be great... good luck ;)

(In [7892]) replaced Spyc with a new YAML parser/dumper (closes #3083, #2887, #2622, #2514, #1966, #1339, #3016)

• removed Spyc
• added sfYamlParser, sfYamlDumper (should be totally BC thanks to the unit tests)
• the parser and the dumper are much more robust and much more easier to fix
• exceptions are thrown when a non valid YAML file is parsed (when you forget a : after a key for example, or if the indentation is not right ;))
• fixed a bunch of bugs of the old parser
• speed is more or less the same as Spyc
• added an option to control the dump to switch from the block to the flow notation (propel:build-schema is now much more readable in YAML)
• added more unit tests