Development

#2118 (sfRequest:hasParameter() doesn't allow for NULL values)

You must first sign up to be able to contribute.

Ticket #2118 (closed defect: fixed)

Opened 3 years ago

Last modified 2 years ago

sfRequest:hasParameter() doesn't allow for NULL values

Reported by: Rihad.Haciyev Assigned to: fabien
Priority: minor Milestone: 1.2.0
Component: other Version: 1.1.0 DEV
Keywords: ParameterHolder, isset Cc:
Qualification: Design decision

Description

To make its decision sfRequest:hasParameter() uses isset(), which unfortunately dose not distinguish between nonexistent values, and explicit NULL values set by user. sfRequest:hasParameter() should be using array_key_exists() instead.

Change History

05/23/08 11:06:35 changed by FabianLange

  • keywords set to ParameterHolder, isset.
  • version changed from 1.0.0 to 1.1.0 DEV.
  • qualification set to Design decision.

i am pretty sure this cannot be changed backwards compatible. So setting this to 1.1. If you Rihad have an idea how to solve this for 1.0 please speak up.

06/23/08 06:34:15 changed by dwhittle

  • milestone set to 1.1.0 FINAL.

06/23/08 15:44:47 changed by fabien

  • milestone changed from 1.1.0 FINAL to 1.2.0.

07/02/08 10:07:39 changed by Carl.Vondrick

No unit tests break if we make this change for 1.2.

08/13/08 13:58:38 changed by fabien

  • status changed from new to closed.
  • resolution set to fixed.

(In [10835]) [1.2] fixed sfRequest:hasParameter() doesn't allow for NULL values (closes #2118)

The Sensio Labs Network

Since 1998, Sensio Labs has been promoting the Open-Source software movement by providing quality web application development, training, consulting.
Sensio Labs also supports several large Open-Source projects.

Open-Source Products

Services

> More