Cache informations in dev mode are not XHTML strict compliant

Personally, I don't think XHTML compliance is really necessary for the development environment as the public won't see it; production environments shouldn't have dev controllers available.

I agree, but when developping it is quiet annoying because i must check all the errors to see wether they come from my html or the generated htlm of the cache infos. (using html validator) and i suppose it would not be very hard to correct ?

Both symfony 1.0 and symfony 1.1 validate against XHTML 1.0 Strict using W3's validator with the debug toolbar active.

Hi Carly, no it is correct. The small div that displays the cache information in debug mode is not valid XHTML:

      <div id="main_3effb7b63927bfa54a7866e2bc5b032c" class="sfWebDebugActionCache" style="border: 1px solid #f00">
      <div id="sub_main_3effb7b63927bfa54a7866e2bc5b032c" class="sfWebDebugCache" style="background-color: #9ff; border-right: 1px solid #f00; border-bottom: 1px solid #f00;">
      <div style="height: 16px; padding: 2px"><a href="#" onclick="sfWebDebugToggle('3effb7b63927bfa54a7866e2bc5b032c'); return false;"><strong>cache information</strong></a>&nbsp;<a href="#" onclick="sfWebDebugToggle('sub_main_3effb7b63927bfa54a7866e2bc5b032c'); document.getElementById('main_3effb7b63927bfa54a7866e2bc5b032c').style.border = 'none'; return false;"><img src="/sf/sf_web_debug/images/close.png" alt="Close" /></a>&nbsp;</div>
        <div style="padding: 2px; display: none" id="3effb7b63927bfa54a7866e2bc5b032c">
        [uri]&nbsp;@sf_cache_partial?module=news&action=_portalNews&sf_cache_key=0<br />

        [life&nbsp;time]&nbsp;3600&nbsp;seconds<br />
        [last&nbsp;modified]&nbsp;0&nbsp;seconds<br />
        &nbsp;<br />&nbsp;
        </div>

you see this violates in the uri:

        [uri]&nbsp;@sf_cache_partial?module=news&action=_portalNews&sf_cache_key=0<br />
}}} where & is not &amp;

as well as ids starting with a letter
{{{
        <div style="padding: 2px; display: none" id="3effb7b63927bfa54a7866e2bc5b032c">
}}}

Patch to comply with XHTML 1.0 strict standards in cache information in web debug

Patch attached for both 1.0 and 1.1. &'s were already properly escaped.

In r7547, r7592, r7593. Please confirm that this fixes it.

Tested, works for me.