Development

#2079 (helper object_admin_input_file_tag() does not care about 'include_remove_text' option)

You must first sign up to be able to contribute.

Ticket #2079 (closed defect: fixed)

Opened 1 year ago

Last modified 8 months ago

helper object_admin_input_file_tag() does not care about 'include_remove_text' option

Reported by: Gilles.Taupenas Assigned to: fabien
Priority: minor Milestone: 1.0.15
Component: helpers Version: 1.0.0
Keywords: Cc:
Qualification: Unreviewed

Description

'include_remove_text' option is not used in lib/vendor/symfony/lib/helper/ObjectAdminHelper.php

To fix it, line 43: 

      $html .= checkbox_tag(strpos($name, ']') !== false ? substr($name, 0, -1).'_remove]' : $name).' '.($include_remove != true ? __($include_remove) : __('remove file'))."\n";

could be replaced by: 

      $include_remove_text = _get_option($options, 'include_remove_text');
      $html .= checkbox_tag(strpos($name, ']') !== false ? substr($name, 0, -1).'_remove]' : $name).' '.($include_remove_text ? __($include_remove_text) : __('remove file'))."\n";

Change History

08/28/07 19:23:28 changed by fabien

  • milestone deleted.

05/07/08 11:46:57 changed by noel

  • status changed from new to closed.
  • resolution set to fixed.
  • qualification set to Unreviewed.

In r8832 and r8831.

Note: You must use the 'include_remove' option instead of 'include_remove_text', which is not documented.

05/07/08 11:50:27 changed by noel

  • milestone set to 1.0.15.

05/22/08 09:44:14 changed by FabianLange

(In [9176]) fixed include_remove in admin helper. this was already in r8831 but got reverted as side effect. closes #2079 again