[PATCH] sfFormValidationPlugin conflicts with object_admin_double_list helper

Confirmed. Propose to change the onsubmit hijack from de admin generator admin double list to call. The hijack could possible also break other enhancements to the admin generator. Reassigned to component generator.

Also check ticket http://trac.symfony-project.com/trac/ticket/1899.

After further invesigations, the problem is related to the sfFormValidation plugin (not within Symfony). sfFormValidation does not take into account an existing onsubmit tag but creates a new tag. The patch uses a regex to scan for an existing "return true;" element if the onsubmit tag exists and adds a "validate(this)" direction to the return.

Index: sfFormValidationPlugin/lib/helper/FormHelper.php
===================================================================
--- sfFormValidationPlugin/lib/helper/FormHelper.php    (revision 28)
+++ sfFormValidationPlugin/lib/helper/FormHelper.php    (working copy)
@@ -140,10 +140,19 @@
     $html_options['enctype'] = 'multipart/form-data';
   }
 
+  // Parse previous onsubmit string and add validat(this) to return
+  if ($onsubmit = _get_option($html_options, 'onsubmit'))
+  {
+    $html_options['onsubmit'] =  preg_replace('/(.*return )true[;]*/i', '\\1 validate(this);', $onsubmit);
+  }
+  else
+  {
+    $html_options['onsubmit'] = 'return validate(this)';
+  }
+
   $html_options['action'] = url_for($url_for_options);
 
   // Added for client side form validation (AN)
-  $html_options['onsubmit'] = 'return validate(this)';
   $lastForm = LastForm::singleton();
   $lastForm->setRoute($url_for_options, $html_options['method']);
   // End client side form validation (AN)

This patch will not offer an solution for cases where already a custom 'return' command has been setup. It is recommended in those situations to revise the developed code to manually include the "validate(this)" command.

v1.1.2 released with bugfix