sfYaml and syck

This fix may well be for my version of syck (0.55) and not something below. It is worth checking.

Correction. gettype(syck_load("")) returns 'unknown type'. But it's the same effect: it is not an array, which is what we want, right?

after looking into this a bit its spyc thats it incorrect as an empty document should be null or undefined

Currently, symfony's configuration process relies on the way spyc works. For example, many of the ConfigHandlers? rely on yamls and, without checking for null, they immediately use a foreach(). I agree that my patch is moving in the opposite direction to what should be the normal behaviour, but it definitely fixes the foreach() errors which result from this difference between syck and spyc.

Here are the locations of all sfYaml::load calls which are not treated as RoVeRT suggests:

addon/propel/sfPropelData.class.php, line 63
         Comment: no checking done
addon/propel/sfPropelData.class.php, line 152
         Comment: immediately uses array_keys on sfYaml::load output
config/sfYamlConfigHandler.class.php, line 57
         Comment: only checks for false. This causes the most trouble.

I suppose there are two solutions.

• Apply the original patch
• Change the behaviour of the above situations and use if ($yaml) after sfYaml::load

I've been told some people are waiting on this patch before using syck, so I have raised the priority by a notch.

fixed in r894.

initial patch applied in r896.