Development

#1982 (Change sfWebDebug "top" css class name)

You must first sign up to be able to contribute.

Ticket #1982 (closed defect: fixed)

Opened 1 year ago

Last modified 1 year ago

Change sfWebDebug "top" css class name

Reported by: SentinelDiety Assigned to: fabien
Priority: minor Milestone: 1.0.6
Component: other Version: 1.0.0
Keywords: sfWebDebug, css Cc:
Qualification:

Description

I think the sfWebDebug css class currently named "top" should be renamed to something more specific to sfWebDebug, say 'sfWebDebugTop'. I have a stylesheet that I inherited that also uses a "top" class, leading to issues both with the debug toolbar and the layout div from conflicting styles.

Reproducing is easy: 1. Create a page with the web debug toolbar enabled. 2. Add a div to that page with the class "top". 3. Set the css style for that new div to height:10px; Other styles to try are setting the background color to light gray, text color to white, etc. 4. Poof! Can't see anything on the web debug toolbar.

I tried to make a patch, but somehow ended up rendering the sfWebDebug divs up at the top unsee-able. :-D

Attachments

main.css.patch (234 bytes) - added by SentinelDiety on 07/17/07 05:51:05.
Patch for symfony_data/web/sf/sf_web_debug/css.main.css
sfWebDebug.php.patch (1.4 kB) - added by SentinelDiety on 07/17/07 05:53:47.
Patch for symfony_lib/debug/sfWebDebug.class.php

Change History

07/17/07 05:51:05 changed by SentinelDiety

  • attachment main.css.patch added.

Patch for symfony_data/web/sf/sf_web_debug/css.main.css

07/17/07 05:53:47 changed by SentinelDiety

  • attachment sfWebDebug.php.patch added.

Patch for symfony_lib/debug/sfWebDebug.class.php

07/17/07 05:54:39 changed by SentinelDiety

Okay I figured out the issue and attached the two patches for the fix.

07/17/07 13:15:34 changed by fabien

  • milestone set to 1.0.6.

07/17/07 13:21:04 changed by fabien

  • status changed from new to closed.
  • resolution set to fixed.

in r4640 and r4641