Development

#1931 (sfWebRequest isSecure() bug for certain server configurations)

You must first sign up to be able to contribute.

Ticket #1931 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

sfWebRequest isSecure() bug for certain server configurations

Reported by: Jonathan.Wage Assigned to: fabien
Priority: minor Milestone: 1.0.6
Component: generator Version: 1.0.0
Keywords: Cc:
Qualification:

Description

Some servers do not return 'on' for HTTPS in the $_SERVER array. You suggested we could just add a new case to the current condition, for it to also check if it is 1 instead of 'on'..

I thought also maybe we could look at the request url protocol to determine if the request is via ssl.

Here is your code snippet from the mailing list.

return (

(isset($pathArrayHTTPS?) && (strtolower($pathArrayHTTPS?)

== 'on' strtolower($pathArrayHTTPS?) == 1))

(isset($pathArrayHTTP_X_FORWARDED_PROTO?) &&

strtolower($pathArrayHTTP_X_FORWARDED_PROTO?) == 'https')

);

Change History

07/17/07 13:32:44 changed by fabien

  • status changed from new to closed.
  • resolution set to fixed.

(In [4642]) fixed sfWebRequest isSecure() bug for certain server configurations (closes #1931)

07/17/07 13:33:17 changed by fabien

in r4643

The Sensio Labs Network

Since 1998, Sensio Labs has been promoting the Open-Source software movement by providing quality web application development, training, consulting.
Sensio Labs also supports several large Open-Source projects.