Development

#1801 (sfRouting - bug with magic_quotes on)

You must first sign up to be able to contribute.

Ticket #1801 (closed defect: fixed)

Opened 2 years ago

Last modified 1 year ago

sfRouting - bug with magic_quotes on

Reported by: Ross.Motley Assigned to: fabien
Priority: minor Milestone:
Component: controller Version: 1.1.0 DEV
Keywords: sfRouting quotes Cc:
Qualification: Ready for core team

Description

On line 583 of sfRouting.class.php (in symfony 1.0.3) there is a call to parse_str() which does not take into account the state of magic quotes. So, just need to change:

parse_str($found, $pass);

To:

parse_str($found, $pass);

if (get_magic_quotes_gpc()) {

$pass = sfToolkit::stripslashesDeep((array) $pass);

}

Attachments

sfRouting_quotes_for_1_1_1801.patch (0.6 kB) - added by FabianLange on 12/20/07 22:46:03.
patch for 1.1 branch

Change History

12/20/07 22:44:38 changed by FabianLange

  • version changed from 1.0.2 to 1.1.0.
  • qualification set to Ready for core team.

hi, this was fixed by noel in r6614 and included in symfony 1.0.10 release, but not yet for 1.1. i attach a patch and direct it to fabien for inclusion in 1.1 as well.

12/20/07 22:46:03 changed by FabianLange

  • attachment sfRouting_quotes_for_1_1_1801.patch added.

patch for 1.1 branch

02/09/08 00:00:06 changed by dwhittle

  • status changed from new to closed.
  • resolution set to fixed.

Fixed in r7426