Development

#1661 ([PATCH] Enable use of open tags in assets)

You must first sign up to be able to contribute.

Ticket #1661 (closed enhancement: fixed)

Opened 3 years ago

Last modified 3 years ago

[PATCH] Enable use of open tags in assets

Reported by: pezetgee Assigned to: fabien
Priority: minor Milestone: 1.1.0
Component: helpers Version: 1.0.0
Keywords: Cc:
Qualification: Unreviewed

Description

Currently the tag() function [TagHelper?.php] doesn't make use of $open parameter. As open parameter may be still required to use I propose the following changes:

settings.yml:

all:
  .settings:
# use open (html style) or closed (xhtml style) tags, false by default
  use_html_tags:  false

TagHelper?.php:

function tag($name, $options = array(), $open = false)
{
  if (!$name)
  {
    return '';
  }

  return '<'.$name._tag_options($options).(($open || sfConfig::get('sf_use_html_tags')) ? '>' : ' />');
}

Obviously relevant changes to doctype, html prolog and favicon link are up to the coder..

Attachments

no_xhtml.diff (1.9 kB) - added by vanchuck on 04/17/07 20:41:50.

Change History

04/17/07 20:41:50 changed by vanchuck

  • attachment no_xhtml.diff added.

04/17/07 20:42:49 changed by vanchuck

  • summary changed from Enable use of open tags in assets to [PATCH] Enable use of open tags in assets.

created a patch of pezetgee's changes

06/06/07 00:00:14 changed by dwhittle

  • status changed from new to closed.
  • resolution set to fixed.

(In [4166]) dwhittle: applied a few patches, fixed some helpers, closes #1677, #1661, #1540, #1531

06/06/07 00:01:14 changed by dwhittle

  • status changed from closed to reopened.
  • resolution deleted.

not committed to trunk yet...

12/07/07 20:54:32 changed by fabien

  • status changed from reopened to closed.
  • resolution set to fixed.
  • qualification set to Unreviewed.

This helper is deprecated in symfony 1.1 and no new feature will be introduced in symfony 1.0. So, this won't be fixed.

This is supported in the new widget framework in symfony 1.1.

12/07/07 20:54:42 changed by fabien

  • milestone set to 1.1.0.

The Sensio Labs Network

Since 1998, Sensio Labs has been promoting the Open-Source software movement by providing quality web application development, training, consulting.
Sensio Labs also supports several large Open-Source projects.