Development

#1540 ([PATCH] input_in_place_editor lacks some options)

You must first sign up to be able to contribute.

Ticket #1540 (closed defect: fixed)

Opened 3 years ago

Last modified 2 years ago

[PATCH] input_in_place_editor lacks some options

Reported by: davedash Assigned to: FabianLange
Priority: minor Milestone: 1.1.0
Component: other Version: 1.0.0
Keywords: Cc:
Qualification: Accepted

Description

the in_place_editor wrapper in JavaScriptHelper? lacks a few options. I added onComplete because that was essential for me.

Attachments

JavascriptHelper.php.diff (0.7 kB) - added by davedash on 03/03/07 18:48:15.
Addition of onComplete option to input_in_place_editor tag
patch-in-place-editor.txt (2.2 kB) - added by xavier on 04/20/07 12:32:26.
cumulative patch
JavascriptHelper.php.patch (451 bytes) - added by Maciej.Filipiak on 09/12/07 12:19:27.
The 'clickToEditText' option is still missing. Patch against trunk.

Change History

03/03/07 18:48:15 changed by davedash

  • attachment JavascriptHelper.php.diff added.

Addition of onComplete option to input_in_place_editor tag

04/20/07 12:32:26 changed by xavier

  • attachment patch-in-place-editor.txt added.

cumulative patch

04/20/07 12:35:04 changed by xavier

  • summary changed from input_in_place_editor lacks some options to [PATCH] input_in_place_editor lacks some options.

I just attached a patch for adding several Protoype's options to symfony's in place editor. This patch is cumulative for #1557 and this ticket.

06/06/07 00:00:14 changed by dwhittle

  • status changed from new to closed.
  • resolution set to fixed.

(In [4166]) dwhittle: applied a few patches, fixed some helpers, closes #1677, #1661, #1540, #1531

06/06/07 00:01:21 changed by dwhittle

  • status changed from closed to reopened.
  • resolution deleted.

not committed to trunk yet...

09/12/07 12:19:27 changed by Maciej.Filipiak

  • attachment JavascriptHelper.php.patch added.

The 'clickToEditText' option is still missing. Patch against trunk.

10/01/07 08:02:56 changed by dwhittle

  • qualification set to Design decision.

Added in changeset #5333. Can you update with one patch for all files.

03/11/08 17:40:26 changed by FabianLange

  • owner changed from fabien to FabianLange.
  • status changed from reopened to new.
  • milestone set to 1.1.0.

oh yet another IPE Ticket. Try to resolve it as well.

03/13/08 10:20:05 changed by FabianLange

  • status changed from new to closed.
  • resolution set to fixed.
  • qualification changed from Design decision to Accepted.

as with r7855 the in place editor will now pass through options as you pass them into. only some special cases have been preserved for backwards compatibility.

The Sensio Labs Network

Since 1998, Sensio Labs has been promoting the Open-Source software movement by providing quality web application development, training, consulting.
Sensio Labs also supports several large Open-Source projects.

Open-Source Products

Services

> More