Development

#1499 (symfony does not encode cookie values properly)

You must first sign up to be able to contribute.

Ticket #1499 (closed defect: fixed)

Opened 2 years ago

Last modified 1 year ago

symfony does not encode cookie values properly

Reported by: dwhittle Assigned to: fabien
Priority: major Milestone:
Component: view Version: 1.0.0
Keywords: Cc:
Qualification: Unreviewed

Description

when symfony sets cookies in sfwebresponse->sendhttpheaders, it is done using setrawcookie. this is bad because the cookie is not urlencoded, as is done with setcookie.

I presume this was intentional to have absolute control of cookie values, but symfony uses these cookies as if they are being encoded automagically, which they are not..

solution: use setcookie or manually call urlencode/urldecode..

Change History

03/19/07 19:34:40 changed by fabien

  • milestone deleted.

02/08/08 23:11:16 changed by dwhittle

  • status changed from new to closed.
  • resolution set to fixed.

(In [7421]) dwhittle: changed cookies to be url encoded by default (by replacing setrawcookie with setcookie), closes #1499

02/09/08 06:13:22 changed by Carl.Vondrick

  • qualification set to Unreviewed.

Not fixed in symfony 1.1's branch yet (but I can't reopen this ticket).

The Sensio Labs Network

Since 1998, Sensio Labs has been promoting the Open-Source software movement by providing quality web application development, training, consulting, and supporting several large Open-Source projects.