Development

#10010 ([Forms] Fixed a notice on PHP 5.4)

You must first sign up to be able to contribute.

Ticket #10010 (closed defect: fixed)

Opened 1 year ago

Last modified 7 months ago

[Forms] Fixed a notice on PHP 5.4

Reported by: Tiago.Ribeiro Assigned to: fabien
Priority: major Milestone: 1.4.20
Component: form Version: 1.4.x DEV
Keywords: Cc:
Qualification: Unreviewed

Description (Last modified by fabien)

Can you add some unit tests?

Attachments

php54.diff (1.7 kB) - added by Tiago.Ribeiro on 03/15/12 11:59:38.
php54-2.diff (1.2 kB) - added by David.Regade on 06/14/12 14:42:06.
patch_symfony_tu_#10010.diff (1.7 kB) - added by bmontuelle on 11/15/12 09:22:23.
unit tests for patch php54-2.diff

Change History

03/15/12 11:59:38 changed by Tiago.Ribeiro

  • attachment php54.diff added.

03/15/12 13:56:20 changed by fabien

  • status changed from new to closed.
  • resolution set to fixed.

(In [33387]) [1.4] fixed some notices on PHP 5.4 (closes #10010, patch from Tiago.Ribeiro)

03/15/12 13:56:35 changed by fabien

  • milestone set to 1.4.18.

03/15/12 14:26:15 changed by zeomni

  • status changed from closed to reopened.
  • resolution deleted.

Hello

Commit [33387] has broken the sfWidgetFormDate

Year select options are empty (display and values) but the number of options is the right one.

03/15/12 14:29:10 changed by clycks

  • priority changed from minor to major.

And sfWidgetFormI18nDateTime too (no more years) in fr culture

03/15/12 14:57:27 changed by tapczan

As far as i can see, all values which are not strings will be nulled. Is there any quick fix for this? I tried copying sfWidget class to lib directory and revert this patch, but it still loads symfony sfWidget.

03/15/12 15:00:24 changed by clycks

quick fix : svn up -r 33373 lib/vendor/symfony/lib/widget/sfWidgetForm.class.php svn up -r 33373 lib/vendor/symfony/lib/widget/sfWidget.class.php

;)

03/15/12 16:01:42 changed by fabien

(In [33388]) reverted r33387 (refs #10010)

03/15/12 16:02:00 changed by fabien

  • milestone deleted.

06/14/12 14:41:45 changed by David.Regade

I made a new patch. I replaced is_tring test with !is_array. That solved the problem with sfWidgetFormDate and sfWidgetFormI18nDateTime and fixed PHP5.4 notice

06/14/12 14:42:06 changed by David.Regade

  • attachment php54-2.diff added.

06/14/12 14:55:02 changed by fabien

Can someone confirm that the new patch works?

11/13/12 14:58:58 changed by bmontuelle

  • status changed from reopened to closed.
  • resolution set to fixed.

Yes it works for us, using PHP version 5.4.6-1ubuntu1

11/13/12 15:43:04 changed by fabien

  • description changed.

11/13/12 15:43:44 changed by fabien

Can you add some unit tests?

11/13/12 15:43:54 changed by fabien

  • status changed from closed to reopened.
  • resolution deleted.

11/15/12 09:22:23 changed by bmontuelle

  • attachment patch_symfony_tu_#10010.diff added.

unit tests for patch php54-2.diff

11/21/12 13:29:31 changed by bmontuelle

  • status changed from reopened to closed.
  • resolution set to fixed.

11/21/12 15:14:22 changed by fabien

(In [33596]) [1.4] fixed some PHP 5.4 notices (closes #10010, patch from Tiago.Ribeiro, David.Regade, and bmontuelle)

11/21/12 15:14:55 changed by fabien

  • milestone set to 1.4.20.