__color__,ticket,summary,component,version,milestone,type,owner,created,_changetime,_description,_reporter
3,1713,Routing does not work correctly in environment with Apache_ suexec and mod_rewrite,routing,1.0.0,,defect,fabien,1177543209,1226228892,Hello all_ When porting a Symfony application over to our web hosting environment_ I discovered a problem with the routing system and our particular configuration. Our hosting environment keeps each user in a secure chroot_ using suexec to run an instance of PHP5 under Apache 2 as the user themselves. However when testing the application I found that the routing didn't seem to be working at all_ except when the script name (e.g._ index.php or mysaleagreed_dev.php) was *not* used in the URL. E.g._ all routing parses were pointing to the homepage_ and when the script name was used_ none of the links to JS or CSS files were working. They came up as /mysaleagreed_dev.php/search/js/... for example_ which is clearly incorrect as it should have been pointing at the web root. I traced the problem to function getScriptName() in request/sfWebRequest.class.php. For a given URL_ say /mysaleagreed_dev.php/search_ it was returning "/mysaleagreed_dev.php/search". Clearly this was incorrect as the series of preg_replaces in the sfRouting class proceeded removed too much - leaving the apparent path to be parsed as just the empty string. Replacing this (line 632 of sfWebRequest.class.php): {{{ return isset($pathArray['SCRIPT_NAME']) ? $pathArray['SCRIPT_NAME'] : (isset($pathArray['ORIG_SCRIPT_NAME']) ? $pathArray['ORIG_SCRIPT_NAME'] : ''); }}} with this: {{{ return isset($pathArray['ORIG_SCRIPT_NAME']) ? $pathArray['ORIG_SCRIPT_NAME'] : (isset($pathArray['SCRIPT_NAME']) ? $pathArray['SCRIPT_NAME'] : ''); }}} hence prioritising ORIG_SCRIPT_NAME if it was available_ since it seemed to hold the correct value_ solved the problem for me. I believe this has something to do with the interaction between suexec and mod_rewrite_ but really am not sure as to the cause. I would be grateful if people could test this patch in a variety of environments and_ if it doesn't cause more problems than it solves_ consider it a candidate for a bugfix for the next incremental release. Thank you all for a truly excellent framework that has revolutionized and vastly sped up the way I do web programming. I hope this ticket is helpful in improving support for different configurations of Apache_ suexec and mod_rewrite. Thank you. Luke Marsden The Property Jungle ,Luke.Marsden
3,1800,sfOutputEscaperObjectDecorator doesn't consider "get" methods in decorated objects,view,1.1.0 DEV,,defect,fabien,1180451161,1219737303,sfOutputEscaperObjectDecorator doesn't consider "get" methods in decorated objects_ it instead calls the get method defined in sfOutputEscaperGetterDecorator. My suggested fix is to derive sfOutputEscaperObjectDecorator directly from sfOutputEscaper.,nightfreak
3,1824,Incorrect handling of empty parameters in routing,routing,1.2.0 DEV,,defect,fabien,1181081295,1264626746,URL generation (with url_for_ genUrl_ link_to_ etc) creates an invalid URL in certain circumstances. Take the following example: url_for('module/action?param1=¶m2=val2') Returns: http://my.domain.com/module/action/param1//param2/val2 .. which does not get properly parsed. It seems to me that it would be best to either have symfony parse "//" as an empty value (if possible)_ or have the URL generation not include empty parameters (thus creating /module/action/param2/val2 from the above example_ completely removing the param1 parameter). Also_ if a trailing ampersand is included at the end of the string to be URL generated_ such as: url_for('module/action?param1=val1&') Returns: http://my.domain.com/module/action/param1/val1%26 .. which appears to get parsed differently depending on if the no_script_name configuration variable is set in settings.yml (effectively making production & development environments act different). With no_script_name set to "off"_ it seems that getRequestParameter('param1') returns "val1". With no_script_name set to "on"_ it returns "val1&". In my situation_ having the URL generation discard trailing question marks_ ampersands_ and slashes_ would be ideal. On a somewhat related note_ it would also be nice if trailing slashes in a URL didn't interfere with pulling up a page. Example: This works fine: http://my.domain.com/module This returns the "oops!" 404 error: http://my.domain.com/module/,Ari.Pringle
3,1852,[PATCH] genUrl bug with GET mode and redirection,controller,1.0.0,,defect,fabien,1181813695,1214235535,Hi I tested my application with sf_url_format different from 'PATH' so the function genUrl in controller/sfWebController.class.php generates url in 'standard' format. But I have arg_separator.output set to &. So when I use the redirect() function_ it separates my arguments with & instead of simply &. I've made a patch for this bug. My patch also corrects another bug due to a wrong usage of the strtr() PHP function. Hope to see my patch be integrated in trunk :) ,Eric.Lemoine
3,2200,[PATCH] sfWebRequest::isSecure vulnerable to MITM attack,controller,1.0.0,,defect,fabien,1189188905,1214566541,isSecure trusts HTTP_X_FORWARDED_PROTO which enables a MITM attacker to make the app believe it is on a secure connection when it actually isn't.,eckhofer
3,9202,Examples,other,1.4.8,,documentation,fabien,1288284470,1288284470,It would be a huge boost of the symfony use if you would extend the documentation pages with a comment like ajax display based for all the api's. Something like (Default display) _____________________________________________ Submit / Browse Usage examples... (After clicking on Submit or Browse) _____________________________________________ Submit Example: New example title: _____________ Code with comments : _____________________________________ _____________________________________ _____________________________________________ Browse Examples: Using sfWidgetFormSchemaFormatterList Example: Action: Template: ________________________ ________________________ ________________________ ________________________ ________________________ ________________________ ________________________ ________________________ ________________________ ________________________ ________________________ ________________________ ________________________ ________________________ ________________________ Aproove link (for admins to accept the post) Format example Example: Action: Template: ________________________ ________________________ ________________________ ________________________ ________________________ ________________________ ________________________ ________________________ ________________________ ________________________ ________________________ ________________________ ________________________ ________________________ ________________________ Aproove link (for admins to accept the post),petronel
3,3628,[PATCH] Make symfony directory & file permission settings user configurable,configuration,1.0.16,,enhancement,fabien,1211649136,1226962408,Symfony has hard-coded directory & file permission settings of 0777 and 0666 scattered throughout the code. These 'world writable' permissions are not only a security risk_ they also 'break' symfony websites on servers that run PHP as a CGI (aka 'phpsuexec': servers running phpsuexec cannot have permissions more than 755 and 644). Symfony sets these 'loose' permissions of 0777 & 0666 in an attempt to make symfony easy to set up and get working on a wide-variety of environments_ which is understandable. But it would be better to make it easy to change the permission settings_ so that more security-minded users could set the permissions as restrictive as possible for their environment. I submit a patch for symfony 1.0.16 which adds new options in php_dir/data_dir/symfony/config/constants.php {{{ sfConfig::add(array( //directory and file permission settings // possible directory values: 0777_ 0775_ 0755_ 0700 // possible file values: 0666_ 0664_ 0644_ 0600 'sf_directory_perm' => $sf_directory_perm = 0755_ 'sf_file_perm' => $sf_file_perm = 0644_ }}} and replaces the hard-coded permissions of 0777 and 0666 in symfony's code with '''sfConfig::get('sf_directory_perm')''' and '''sfConfig::get('sf_file_perm')''' Sample 'fix_perms' function in php_dir/data_dir/symfony/tasks/sfPakeMisc.php {{{ function run_fix_perms($task_ $args) { $sf_root_dir = sfConfig::get('sf_root_dir'); pake_chmod(sfConfig::get('sf_cache_dir_name')_ $sf_root_dir_ sfConfig::get('sf_directory_perm')); pake_chmod(sfConfig::get('sf_log_dir_name')_ $sf_root_dir_ sfConfig::get('sf_directory_perm')); pake_chmod(sfConfig::get('sf_web_dir_name').DIRECTORY_SEPARATOR.sfConfig::get('sf_upload_dir_name')_ $sf_root_dir_ sfConfig::get('sf_directory_perm')); pake_chmod('symfony'_ $sf_root_dir_ sfConfig::get('sf_directory_perm')); $dirs = array(sfConfig::get('sf_cache_dir_name')_ sfConfig::get('sf_web_dir_name').DIRECTORY_SEPARATOR.sfConfig::get('sf_upload_dir_name')_ sfConfig::get('sf_log_dir_name')); $dir_finder = pakeFinder::type('dir')->ignore_version_control(); $file_finder = pakeFinder::type('file')->ignore_version_control(); foreach ($dirs as $dir) { pake_chmod($dir_finder_ $dir_ sfConfig::get('sf_directory_perm')); pake_chmod($file_finder_ $dir_ sfConfig::get('sf_file_perm')); } } }}} Please see verbose thread for more information on phpsuexec http://www.symfony-project.org/forum/index.php/m/43604/#msg_43604 and wiki contribution here: http://trac.symfony-project.com/wiki/SymfonyPHPsuexec and related dev group discussion here: http://groups.google.com/group/symfony-devs/browse_thread/thread/afeee2a065ca5910?hl=en '''Please note that these 'hard-coded' permission settings also exist in symfony 1.1.''' Any feedback on patch/concept is much appreciated! ,jillelaine
3,7242,secure form from altered values,form,,,enhancement,bschussek,1254210069,1272529225,The sfForm framework should have a secureFields(array of fields) method_ this method should add an hidden field which compute the values of each fields into a md5/sha1 string. So when the form is posted the attached validator can compute the new hash and check if the fields' values have been altered. This will add more security against people changing hidden fields' values or readonly input. ,rande
3,1061,[PATCH] sfBasicSecurityFilter should not secure the "secure" action either,cache,,1.0.8,defect,fabien,1162510945,1246482459,Doesn't make much sense to secure the secure Action of your app either_ here's a patch: {{{ Index: sfBasicSecurityFilter.class.php =================================================================== --- sfBasicSecurityFilter.class.php (revision 2607) +++ sfBasicSecurityFilter.class.php (working copy) @@ -41_7 +41_9 @@ $actionInstance = $actionEntry->getActionInstance(); // disable security on [sf_login_module] / [sf_login_action] - if ((sfConfig::get('sf_login_module') == $context->getModuleName()) && (sfConfig::get('sf_login_action') == $context->getActionName())) + // or [sf_secure_module] / [sf_secure_action] + if (((sfConfig::get('sf_login_module') == $context->getModuleName()) && (sfConfig::get('sf_login_action') == $context->getActionName())) + || ((sfConfig::get('sf_secure_module') == $context->getModuleName()) && (sfConfig::get('sf_secure_action') == $context->getActionName()))) { $filterChain->execute(); }}} ,davedash
3,2035,Own PartialView.class.php or MailView.class.php,other,1.0.5,1.2.0,defect,fabien,1185552369,1228393675,We can override sfView.class.php and use own class if we setting "view_class" parameter in module.yml_ but we can't do the same with sfPartialView.class.php I propose fix bellow: File: PartialHelper.php_ Line: 193 {{{ // render $view = new sfPartialView(); }}} And after fix: {{{ $setting_name = 'mod_'.$moduleName.'_partial_view_class'; $partial_view_class = sfConfig::get($setting_name_ 'sf').'PartialView'; // render $view = new $partial_view_class(); }}} ,Dawid.Szalega
4,2302,issues with CLI,other,1.0.7,None,defect,fabien,1191105929,1226234360,Generally symfony internally seems unaware if its run as a CLI script in several places. This results in pake tasks attempting to create a session store_ batch scripts attempting to set http headers or generate metas. Furthermore calls to actions in batch scripts are not considered to be internal. Here is an overview of the problems and some suggested fixes: 1) batch/pake scripts should by default set some constant to make it easy to detect if the request is a CLI call 2) this constant should be checked in sfRenderFilter before attempting to send the http headers. Additionally it should be considered to check if headers have already been sent (this suggestion is independent if the CLI) 3) this constant should also be checked in order to determine if an action is being called internally or not 4) in sfYamlConfigHandler the mergeConfigValue() method should not attempt to array_merge() if the value in the specific config is empty() 5) this constant should be checked in order to determine if the session store should be loaded. this should at the very least be the case for pake tasks_ otherwise you can run into boot strapping issues if you are trying to setup tables via a pake tasks that are needed for the session storage. backporting the nostorage container might be an alternative.,lsmith
4,2932,[PATCH] Exception handling for Date Input in admin-generated CRUD pages,generator,1.0.10,None,defect,fabien,1202916744,1202934305,Currently timestamp related fields in admin-generated CRUD pages dont report errors in data entry. They silently pass of with neither modifying the column value nor reporting error. 1.Enter an invalid date string "sdfdsfsdf" into timestamp textbox.,manickam
4,2961,sfWebBrowserPlugin cant find form items with $ in there name.,sfWebBrowserPlugin,1.0.11,None,defect,,1203366001,1251470172,To be honest_ ive only ever noticed them on one site_ and that just has to be the one i need to authenticate on ;-)( to see the code - view the source of this URL_ or run teh code below (probly best not to hammer that server though - its not mine) $b = new sfWebBrowser(array()_ 'sfCurlAdapter'); $b->get('http://ematrix.genusvs.co.uk/login.aspx'); $res = $b->getResponseText(); print $res; ... ... to authenticate I'm using. $b->get('http://ematrix.genusvs.co.uk/login.aspx') ->setField('Login1$UserName'_ 'MYUSERNAME') ->setField('Login1$Password'_ 'MYPASSWORD') ->click('Login1$btnLogin'); I've also tried. $b->get('http://ematrix.genusvs.co.uk/login.aspx') ->setField('Login1\$UserName'_ 'MYUSERNAME') ->setField('Login1\$Password'_ 'MYPASSWORD') ->click('Login1\$btnLogin'); but cant find an escaping strategy that works ,DerekAlmond
4,2071,Adding location information and flag deleted keys when using smyfony to automatically add and delete translation keys,i18n,1.0.0,None,enhancement,fabien,1186141647,1258313792,When having symfony automatically add/delete translations_ it might be a good to optionally add a column to flag items as deleted (this of course would mean we need to expand the table). It frequently happens that someone thinks its a good idea to fix a typo in the templates or that someone screwed up when he initially set up the template by not using placeholders for text strings. It would be good to not loose the translations in those cases. In that case it would also be very useful to storage inside a comment in which file a translation was initially found. Now leveraging the information of where the keys were found initially would then make it easy to find these old translation keys.,lsmith
4,2988,fromArray method doesn't populate i18n fields,i18n,1.1.0 DEV,None,enhancement,fabien,1203619692,1258313792,for i18n objects_ passing an array to the ''fromArray'' method on a propel created model object will only update the fields of that object_ but not the corresponding i18n object. Calling individual setter methods will do that however. For my purposes I added an ''addFromArray'' method in ''sf/lib/addon/propel/builder/sfObjectBuilder''_ overwriting its parent_ so that i18n objects call the fromArray method on their i18n partner object_ passing the same array and fieldType. Looks a little hacky_ but I attached it so somebody smarter can polish it up_ maybe for the next release. ,Richtermeister
4,4447,Added session storage adapter for cookie sessions.,other,,None,enhancement,dwhittle,1222075116,1258313792,For 1.3_ we should provide session factories for signed cookie based sessions. * sfCookieSessionStorage ,dwhittle
4,1426,Rename the propel plugins with "propel" in their name as explained in the book,plugins,,,defect,fabien,1170745729,1210452563,`sfErrorLoggerPlugin` → `sfPropelErrorLoggerPlugin` `sfGuardPlugin` → `sfPropelGuardPlugin`,chtito
4,1688,[sfTestBrowser] PHP compression in test env makes functional sfTestBrowser tests return with no output (or error),tests,1.0.0,,defect,fabien,1176949857,1191221021,in my case_ compression for the test env was enabled inadvertently via {{{ all: .settings: compressed: on }}} any functional tests with sfTestBrowser calls return no output or errors with response compression enabled. if this cant be fixed_ sfTestBrowser should throw an exception if compression is enabled for the test environment. in addition_ this should be noted in the documentation giving the [http://www.symfony-project.com/book/trunk/15-Unit-and-Functional-Testing#Working%20in%20the%20Test%20Environment default test environment settings]: {{{ compressed: off }}} should be added to this default config.,hansbrix
4,1736,Component cache broken when sf_culture in the url,cache,1.0.2,,defect,fabien,1178657073,1214300405,When i want to use Culture in the URL i can't cache perfectly the component_slots. For example: when i do a request with sf_culture=en at first try it's work good_ but if i change the sf_culture parameter for other ex. hu_ my sites change the language perfectly without the component_slots because it is cached with the first version and doesn't changed to the new language after page reload. (symfony versions has this bug: 1.0.x - i tried its) I think component_slots cache does not handle sf_culture when it is in the url.,Peter.Veres
4,3189,YAML Constants and relative paths in view.yml files,view,1.0.12,,defect,fabien,1206357065,1214300923,To be able to use constants and relative path like (../../../templates/mail.php) to use project wide templates I had to make the following improvements: {{{ =================================================================== --- lib/config/sfViewConfigHandler.class.php (Revision 8061) +++ lib/config/sfViewConfigHandler.class.php (Arbeitskopie) @@ -192_7 +192_7 @@ { $data = ''; - if ($this->getConfigValue('has_layout'_ $viewName) && false !== $layout = $this->getConfigValue('layout'_ $viewName)) + if ($this->getConfigValue('has_layout'_ $viewName) && false !== $layout = $this->replaceConstants($this->getConfigValue('layout'_ $viewName))) { $data = " \$this->setDecoratorTemplate('$layout'.\$this->getExtension());\n"; } }}} Just a quick and dirty solution. {{{ Index: lib/view/sfView.class.php =================================================================== --- lib/view/sfView.class.php (Revision 8061) +++ lib/view/sfView.class.php (Arbeitskopie) @@ -541_8 +541_8 @@ { $this->decoratorTemplate = $template; } - - if (!strpos($this->decoratorTemplate_ '.')) + + if (strpos($this->decoratorTemplate_ '.') === false) { $this->decoratorTemplate .= $this->getExtension(); } }}} This is only a quick and dirty solution. Please use a regularly expression_ because perhaps I could use relative paths like ../../ and this would be interpretated as true. Generally: Please do not use the expression !strpos in your code because if the needle was found at position zero_ it is interpretated as false. please use strpos(...) === false The same in 1.1 please! Thanks!,svewap
4,4046,sfValidatorAnd breaks enforcement of required rule,validation,1.1.0,,defect,fabien,1216595592,1238777153,When using sfValidatorAnd to combine two validators_ one of which requires some value (such as sfValidatorString)_ the required rule is not enforced. Example. If I use CRUD to generate a simple form from a schema with a field called "first_name" and set it to be required_ my base form class includes some validation such as: {{{ $this->setValidators(array( 'first_name' => new sfValidatorString(array('max_length' => 20)) )); }}} If I attempt to add a record using the CRUD generated classes_ the required rule is enforced on the first_name field. But_ if I add additional validation to the first_name field using sfValidator: {{{ $this->validatorSchema['first_name'] = new sfValidatorAnd(array ( $this->validatorSchema['first_name']_ new sfValidatorString(array('max_length' => 255)) )); }}} ...then the required rule is no longer enforced_ regardless of what sort of additional validator I add in. ,slantedview
4,5150,Incorrect "for" attribute of labels for sfWidgetForm(I18n)Date,form,1.2.0,,defect,fabien,1228250235,1233005169,The "for" value for a label rendered for a (i18n) date widget should be the id of one the three generated select boxes. For example these id's are myform_datewidget_year_ myform_datewidget_month and myform_datewidget_day. Currently the for attribute is then incorrectly set to myform_datewidget.,Dennis.Verspuij
4,6552,sfGuardAuth redirects to favicon.ico after logging in,configuration,1.2.7,,defect,fabien,1243624562,1264211711,== Scenario == * Installed Symfony * Created Application * Created Module * Edited modules' security.yml to: {{{ default: is_secure: on }}} One thing to mention here: web/favicon.ico does not exist by default_ but module/x/templates/layout.php refers to web/favicon.ico by default. == Defect == sfGuardAuth redirects (not always_ but repeatly) to favicon.ico as long as the file does not exist and the call end up in the symfony framework due to RewriteRule of default .htaccess. == How to reproduce == * Call URL for Module * Login appears * Login * If redirect was correct_ logout_ proceed with first step. Depends on browser_ its settings_ client caching etc. == Workaround == Either create a favicon.ico or remove the '''' line from the layout. == Possible Fixes == * Remove the referer to the favicon.ico from the default layout.php of a module. * Create and ship a default favicon.ico (perhaps the symfony one?) to make the referer valid.,tuebernickel
4,6563,filters dont allow custom selects,generator,1.2.7,,defect,fabien,1243871245,1245229841,In schema.sql: gender: varachar(1) in GenderFilter.class {{{ class GenderFilter extends GenderFilter { public function configure() { $this->setWidget('anrede'_ new sfWidgetFormChoice(array('choices' => GenderPeer::$genders))); $this->setValidator('anrede'_ new sfValidatorChoice(array('choices' => array_keys(GenderPeer::$genders)_ 'required' => false))); } } }}} and the corresponding variable $genders in GenderPeer should be everything to get a custom filter working. The Problem is_ that the list does NOT get filtered accordingly. (The selected gender however is correctly remembered and preselected in the filter div) the according autoaction expects $this->filters['gender']['text'] = 'f'; but 'text' is not created by sfWidgetFormChoice ,zevero
4,7927,[PATCH] ambiguous documentation ?,website,1.4.1,,documentation,Jonathan.Wage,1260958389,1276717192, I was reading this page: http://www.symfony-project.org/advent_calendar/11/en and i've come across something which i thing can be a little clearer. It says that in order to enable DQL callbacks i shoulr enable a doctrine attribute but it dosn't say where to do this or how. $manager->setAttribute(Doctrine_Core::ATTR_USE_DQL_CALLBACKS_ true);,mlmarius
4,9130,Jobeet/Day 1 : Starting up the Project /Web Server Configuration (bad info),jobeet,1.4.8,,documentation,fabien,1286265277,1286265277,In te notice zone you tell us that the apache virtual host alias configuration should be : {{{ Alias /sf "c:\dev\sfprojects\jobeet\lib\vendor\symfony\data\web\sf" }}} and the DocumentRoot has to have the form {{{ c:\dev\sfprojects\jobeet\web }}} but it is an error windows apache does not support back slashes for those but only normal slashes "/" all the directory backslashes "\" mut be remplaced by the normal slash "/" and hold the normal nomination path. If apache find any backslash it will not start.,symfonyboy
4,9512,documentation/bg_BG,other,1.3.0,,documentation,fabien,1297776513,1297778831,Български превод ,Veskopolo
4,3936,[PATCH] RFC4946 (rel=license),sfFeed2Plugin,1.0.17,,enhancement,Kris.Wallsmith,1215512517,1225583281,There is no way to provide license information (RFC4946) for Atom feeds (rel="license"). The atom:link support is very limited_ so as a workaround the attached patch simply adds a new license option rather then general atom:link support. This is an extremely simplified "implementation" of the RFC. Note: Due to limitations of this component adding support for the http://backend.userland.com/creativeCommonsRssModule namespace for RSS is beyond the scope of this workaround. ,bjori
4,4165,Special characters are not displayed in the widget with the default options,widget,1.1.0,,enhancement,fabien,1218228532,1221210261,Characters like á_ é_ í_ ... etc. are not displayed in the widget with the default options_ for example 'name' => new sfWidgetFormSelect( array('choices' => array("árbol"=>"árbol")) ) display In file sfWidget is $charset = 'UTF-8' by default_ but you can´t configure it in any file. I think that if you set the encoding in settings.yml the widget should take that or maybe from another file. in settings.yml all: .settings: charset: iso8859-1,botero82
4,5013,Add sfGotoRoute,other,1.2.0,,enhancement,fabien,1227206102,1231678476,This patch complete the patches of #5005 by adding a route able to jump to another route by name during parsing. Example usage in routing.yml: {{{ mygotoroute: url: ^/prefix class: sfGotoRoute options: { route: route_name } }}} If the URL start with /prefix_ jump directly to the route name "route_name" and continue parsing. ,rs
4,6316,Add stream handling capabilities to sfFileCache,cache,1.2.5,,enhancement,fabien,1240235559,1244128505,Would be nice to be able to pass streams to sfFileCache to store and also get streams out of sfFileCache instead of just the file string. This helps with memory usage when working with large files.,KRavEN
4,6323,Accept filter parameters in POST,dbFinderPlugin,1.2.1,,enhancement,francois,1240374775,1240557735,It would be awesome if the filter parameters of a route could come in the POST parameters. Right now it checks the getQueryString method wich only uses GET parameters for the variables to filter. I think it could be nice to have them by POST. I use post a lot to avoid AJAX cache issues with internet explorer in simple queries.,ivanrey
4,6559,[PATCH] Disabled options in select widget,widget,1.2.0 DEV,,enhancement,fabien,1243848595,1244402887,I was trying to set some select options disabled attribute but current implementation doesn't allow such thing. Included is my patch for this feature (backward compatible) example: {{{ class ExampleForm extends sfForm { public function setup() { $choices = array(1 => 'first'_ 2 => 'second'_ 3 => 'disabled') $disabled = array(3); $this->setWidgets(array( 'select' => new sfWidgetFormSelect(array( 'choices' => $choices_ 'disabled' => $disabled)) )); $this->setValidators(array( 'select' => new sfValidatorChoice(array('choices' => array_keys($choices))) )); $this->errorSchema = new sfValidatorErrorSchema($this->validatorSchema); parent::setup(); } } }}},mrhyde
4,7146,[PATCH] sfWidgetFormDoctrineChoice - parameters for table_method,form,1.2.7,,enhancement,fabien,1252741293,1317745264,When adding a choice widget sometimes we need to call a model method_ with some arguments. I added possibility to send parameters for table method_ for preparing choices array. '''As of PHP 5.3.0''' Use case: {{{ class AccountTable extends Doctrine_Table { public function getUserActiveAccounts(HbUser $usr) { //code } } // creating widget: new sfWidgetFormDoctrineChoice(array( 'model' => 'Account'_ 'table_method' => array('method' => 'getUserActiveAccounts'_ 'parameters' => array($this->usr)) )); }}} ,lukasszz
4,8387,[PATCH] sfMemcacheCache won't throw an exception if configured server is unavailable,cache,1.4.3,1.4.11,defect,fabien,1268062200,1268149104,All is in the title. `Memcache::addServer()` can return true even if the added server is not available. Attached is a patch which will check server connectivity status using the `getServerStatus` method.,nicolas
4,6015,Update sfPJS plugin description now that functionality is included in sf1.2,sfPJSPlugin,1.2.4,plugins,defect,fabien,1236111921,1265492901,It took me over 1.5 hours of trying to make sfPJS work in sf1.2 before I discovered that it has been replaced with use_dynamic_javascript(). Please update the sfPJS plugin page to reflect this!,hackel
4,6899,csSEOToolkitPlugin - memory leaks on remove404 task,plugins,1.2.8,plugins,defect,bshaffer,1248436611,1253116515,My remove404 task times out about halfway through_ which removes its value_ as you don't clear offending pages until the end of the task.,bshaffer
4,3552,php-generator code should return php-template code_ using sfExtjs2Plugin (not directly JS code),sfExtjsThemePlugin,1.0.16,plugins,enhancement,,1210859580,1218119713,the php-generator code should return php-template code_ but currently at some places directly returns js-code_ this should all be php-template code using the sfExtjs2Plugin. This way you can much easier make changes to the code_ when copying it from cache to a template folder.,Leon.van.der.Ree