Development

Changeset 9321

You must first sign up to be able to contribute.

Changeset 9321

Show
Ignore:
Timestamp:
05/27/08 17:56:43 (5 years ago)
Author:
gordon
Message:

sfRatingPlugin found some problems ;(

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved

  • plugins/sfRatingPlugin/trunk/lib/behavior/sfRatingDoctrineTemplate.class.php

    r9317 r9321  
    300300  { 
    301301    $field = sfRatingToolkit::getObjectRatingField($object); 
     302//TODO: add test 
     303//    var_dump($field); 
    302304    if (!is_null($field))  
    303305    { 

  • plugins/sfRatingPlugin/trunk/lib/sfRatingToolkit.class.php

    r9317 r9321  
    165165  public static function getObjectRatingField($object) 
    166166  { 
    167     return sfConfig::get(sprintf('app_rating_%s_rating_field', get_class($object))); 
     167    $class_config = sfConfig::get('app_rating_' . get_class($object)); 
     168//TODO: add test when ratingField is set Fatal error: Call to undefined method sfRatingToolkit::getratingtoobject() in 
     169//    var_dump('app_rating_%s' . get_class($object)); 
     170//    var_dump($class_config); 
     171//    return isset($class_config['ratingField']) ? $class_config['ratingField']:null; 
     172    return null; 
    168173  } 
    169174 
    …… 
    181186    } 
    182187 
    183     return sfConfig::get(sprintf('app_rating_%s_reference_field', $object_name)); 
     188    $class_config = sfConfig::get('app_rating_' . $object_name); 
     189//TODO: add test when referenceField is set 
     190//    var_dump('app_rating_%s' . $object_name); 
     191//    var_dump($class_config); 
     192    return isset($class_config['referenceField']) ? $class_config['referenceField']:null; 
    184193  } 
    185194   

  • plugins/sfRatingPlugin/trunk/test/unit/sfRatingDoctrineTest.php

    r9317 r9321  
    136136$obj1->clearRatings(); 
    137137$obj2->clearRatings(); 
    138 sfConfig::set( 
    139     sprintf('propel_behavior_sfPropelActAsRatableBehavior_%s_max_rating',  
    140             get_class($obj1)), 10); 
     138sfConfig::set(sprintf('app_rating_%s_max', get_class($obj1)), 10); 
    141139 
    142140$obj1->setRating(4, $user_1_id);