Changeset 8883

Timestamp:

05/09/08 15:58:04 (1 year ago)

Author:

fabien

Message:

added an exception when binding a multipart form without a files argument

Files:

• branches/1.1/lib/form/sfForm.class.php (modified) (2 diffs)
• branches/1.1/test/unit/form/sfFormTest.php (modified) (2 diffs)

branches/1.1/lib/form/sfForm.class.php

@@ -126 +126 @@
-   * @param array An array of uploaded files (in the $_FILES or $_GET format)
-   */
-array()
+null
-  {
-    $this->taintedValues = $taintedValues;
@@ -136 +136 @@
-    {
-      $this->taintedValues = array();
+    }
+
+    if (is_null($this->taintedFiles))
+    {
+      if ($this->isMultipart())
+      {
+        throw new InvalidArgumentException('This form is multipart, which means you need to supply a files array as the bind() method second argument.');
+      }
+
+      $this->taintedFiles = array();
-    }
-

branches/1.1/test/unit/form/sfFormTest.php

@@ -11 +11 @@
-require_once(dirname(__FILE__).'/../../bootstrap/unit.php');
-
-7
+8
-
-class FormTest extends sfForm
@@ -214 +214 @@
-  'file' => new sfValidatorFile(array('max_size' => 2)),
-)));
-
-
-
-
-
+
+
+
+
-$t->is($f->getErrorSchema()->getCode(), '1 [min_length] file [max_size]', '->bind() behaves correctly with files');
+
+try
+{
+  $f->bind(array(1 => 'f', 2 => 'potencier'));
+  $t->fail('->bind() second argument is mandatory if the form is multipart');
+}
+catch (InvalidArgumentException $e)
+{
+  $t->pass('->bind() second argument is mandatory if the form is multipart');
+}
-
-// ->renderGlobalErrors()