Changeset 8698

Timestamp:

04/30/08 18:35:28 (1 year ago)

Author:

fabien

Message:

added an exception when trying to retrieve a non existant sfEvent parameter (to ease debugging) lib/event/sfEvent.class.php test/unit/event/sfEventTest.php

Files:

• branches/1.1/lib/autoload/sfCoreAutoload.class.php (modified) (1 diff)
• branches/1.1/lib/event/sfEvent.class.php (modified) (2 diffs)
• branches/1.1/test/unit/event/sfEventTest.php (modified) (2 diffs)

branches/1.1/lib/autoload/sfCoreAutoload.class.php

@@ -292 +292 @@
-  'sfDatabaseSessionStorage' => 'storage',
-  'sfMySQLSessionStorage' => 'storage',
+  'sfMySQLiSessionStorage' => 'storage',
-  'sfNoStorage' => 'storage',
-  'sfPDOSessionStorage' => 'storage',

branches/1.1/lib/event/sfEvent.class.php

@@ -120 +120 @@
-  public function offsetExists($name)
-  {
-isset($this->parameters[$name]
+array_key_exists($name, $this->parameters
-  }
-
@@ -132 +132 @@
-  public function offsetGet($name)
-  {
-
+
+
+
+
+
+
-  }
-

branches/1.1/test/unit/event/sfEventTest.php

@@ -11 +11 @@
-require_once(dirname(__FILE__).'/../../bootstrap/unit.php');
-
-0
+1
-
-$subject = new stdClass();
@@ -47 +47 @@
-$t->is($event['foo'], 'foo', 'sfEvent implements the ArrayAccess interface');
-
+try
+{
+  $event['foobar'];
+  $t->fail('::offsetGet() throws an InvalidArgumentException exception when the parameter does not exist');
+}
+catch (InvalidArgumentException $e)
+{
+  $t->pass('::offsetGet() throws an InvalidArgumentException exception when the parameter does not exist');
+}
+
-$t->ok(isset($event['foo']), 'sfEvent implements the ArrayAccess interface');
-unset($event['foo']);