Changeset 6585

Timestamp:

12/19/07 13:44:44 (6 years ago)

Author:

kubens

Message:

Added sf_extjs2_comment

Files:

• plugins/sfExtjs2Plugin/trunk/config/config.php (modified) (2 diffs)
• plugins/sfExtjs2Plugin/trunk/lib/helper/sfExtjs2Helper.php (modified) (9 diffs)

plugins/sfExtjs2Plugin/trunk/config/config.php

@@ -1 +1 @@
-<?php
-
+
+
-#
-# array values that don't need quotes
@@ -58 +59 @@
-# attributes which must handled as array
-#
-cm', 'ds', '
+
-#
-# mapping plugin method against class

plugins/sfExtjs2Plugin/trunk/lib/helper/sfExtjs2Helper.php

@@ -5 +5 @@
- * @description      sfExtjs2Plugin is a symfony plugin that provides an easy to use wrapper for the Ext javascript library
- * @author           Benjamin Runnels<benjamin.r.runnels [at] citi [dot] com>, Leon van der Ree, Wolfgang Kubens<wolfgang.kubens [at] gmx [dot] net> 
-
-
+
+
+
+
- *                    - handling of inner (recursive) arrays (see items => array(array(...), array(...))
- *                   12.17.2007 Kubens:
@@ -166 +168 @@
-    foreach (sfConfig::get('sf_extjs2_list_attributes') as $attribute) 
-    {
-
+  && !$attributes['attributes'][$attribute] instanceof sfExtjs2Var
-      {
-        $attributes['attributes'][$attribute] = sprintf('[%s]', sfExtjs2Plugin::_build_attributes($attributes['attributes'][$attribute]));
@@ -261 +263 @@
-    $source  = sfExtjs2Plugin::LBR;
-    $source .= sprintf("<script type='text/javascript'>%s", sfExtjs2Plugin::LBR);
+    $source .= sfExtjs2Plugin::_comment(sprintf("%s// sfExtjs2Helper: %s%s", sfExtjs2Plugin::LBR, sfConfig::get('sf_extjs2_version'), sfExtjs2Plugin::LBR));
-    $source .= sprintf("Ext.BLANK_IMAGE_URL = '%s'%s", sfConfig::get('sf_extjs2_spacer'), sfExtjs2Plugin::LBR_SM);
-
@@ -297 +300 @@
-    {
-      $this->namespace = $namespace;
+      $source .= sfExtjs2Plugin::_comment(sprintf("%s// namespace: %s%s", sfExtjs2Plugin::LBR, $namespace, sfExtjs2Plugin::LBR)); 
-      $source .= sprintf("Ext.namespace('%s')%s", $namespace, sfExtjs2Plugin::LBR_SM);
-    }
-
-    // write class tag
+    $source .= sfExtjs2Plugin::_comment(sprintf("%s// class: %s.%s%s", sfExtjs2Plugin::LBR, $namespace, $classname, sfExtjs2Plugin::LBR));
-    $source .= sprintf("%s.%s = Ext.extend(%s, {%s", $namespace, $classname, $extend, sfExtjs2Plugin::LBR);
-
@@ -317 +322 @@
-  {
-    $source  = '';
-"
+%s", sfExtjs2Plugin::LBR_SM
-
-    echo $source;
@@ -351 +356 @@
-
-    // write application syntax
-
-
-
+
+
+
+
-      $attributes['name'],
+      sfExtjs2Plugin::LBR,
+      sfExtjs2Plugin::LBR,
-      $sourcePrivate,
-      $sourcePrivate != '' ? sfExtjs2Plugin::LBR : '',
@@ -372 +380 @@
-  {
-    $source  = '';
-}}()%s"
+%s}}()%s", sfExtjs2Plugin::LBR
-
-    echo $source;
@@ -449 +457 @@
-  private static function _build_attributes ($custom_attributes = array(), $default_attributes = array())
-  {
-    $merged_attributes = array_merge($default_attributes, $custom_attributes);
-
-    $attributes = '';
+
+    $merged_attributes = $default_attributes;
+    if (is_array($custom_attributes) && is_array($default_attributes))
+    {
+      $merged_attributes = array_merge($default_attributes, $custom_attributes);
+    }
+
-    foreach ($merged_attributes as $key => $value)
-    {
@@ -546 +559 @@
-  }
-
+  /**
+   * @param string comment
+   * @return string comment
+   */  
+  private static function _comment($comment)
+  {
+    if (sfConfig::get('sf_extjs2_comment'))
+    {
+      return $comment;
+    }
+    else 
+    {
+      return '';
+    }
+  }
+
-}
-