Changeset 33390

Timestamp:

03/21/12 22:12:23 (1 year ago)

Author:

boutell

Message:

Tags should be sorted in a case-insensitive fashion for consistency with the results of sorting them with MySQL and for general friendliness

Files:

• plugins/sfDoctrineActAsTaggablePlugin/trunk/lib/model/doctrine/PluginTagTable.class.php (modified) (1 diff)

plugins/sfDoctrineActAsTaggablePlugin/trunk/lib/model/doctrine/PluginTagTable.class.php

@@ -177 +177 @@
-        if (!isset($options['sort_by_popularity']) || (true !== $options['sort_by_popularity']))
-        {
-ksort($tags
+uksort($tags, array('TagTable', 'compareTags')
-        }
-
-        return $tags;
+    }
+
+    /**
+     * Case insensitive comparison so results when sort_by_popularity is false are
+     * comparable to the results of MySQL doing the sorting (as seen most other places
+     * in a Symfony app)
+     */
+    static public function compareTags($a, $b)
+    {
+        return strcasecmp($a, $b);
-    }
-