Changeset 23984

Timestamp:

11/15/09 20:54:59 (3 years ago)

Author:

FabianLange

Message:

[1.0, 1.2, 1.3, 1.4] not setting status header for servers in cgi-sapi mode (fixes #3191)

Files:

• branches/1.0/lib/response/sfWebResponse.class.php (modified) (2 diffs)
• branches/1.2/lib/response/sfWebResponse.class.php (modified) (2 diffs)
• branches/1.3/lib/response/sfWebResponse.class.php (modified) (1 diff)
• branches/1.4/lib/response/sfWebResponse.class.php (modified) (1 diff)

branches/1.0/lib/response/sfWebResponse.class.php

@@ -260 +260 @@
-  public function sendHttpHeaders()
-  {
+    $headers = $this->getParameterHolder()->getAll('symfony/response/http/headers')
+
-    // status
-    $status = 'HTTP/1.0 '.$this->statusCode.' '.$this->statusText;
-    header($status);
-
+    if (substr(php_sapi_name(), 0, 3) == 'cgi')
+    {
+      // fastcgi servers cannot send this status information because it was sent by them already due to the HTT/1.0 line
+      // so we can safely unset them. see ticket #3191
+      unset($headers['Status']);
+    }
+
-    if (sfConfig::get('sf_logging_enabled'))
-    {
@@ -270 +279 @@
-
-    // headers
-this->getParameterHolder()->getAll('symfony/response/http/headers')
+headers
-    {
-      header($name.': '.$value);

branches/1.2/lib/response/sfWebResponse.class.php

@@ -335 +335 @@
-    header($status);
-
+    if (substr(php_sapi_name(), 0, 3) == 'cgi')
+    {
+      // fastcgi servers cannot send this status information because it was sent by them already due to the HTT/1.0 line
+      // so we can safely unset them. see ticket #3191
+      unset($this->headers['Status']);
+    }
+
-    if ($this->options['logging'])
-    {
@@ -345 +352 @@
-      $this->setContentType($this->options['content_type']);
-    }
+
-    foreach ($this->headers as $name => $value)
-    {

branches/1.3/lib/response/sfWebResponse.class.php

@@ -336 +336 @@
-    header($status);
-
+    if (substr(php_sapi_name(), 0, 3) == 'cgi')
+    {
+      // fastcgi servers cannot send this status information because it was sent by them already due to the HTT/1.0 line
+      // so we can safely unset them. see ticket #3191
+      unset($this->headers['Status']);
+    }
+
-    if ($this->options['logging'])
-    {

branches/1.4/lib/response/sfWebResponse.class.php

@@ -336 +336 @@
-    header($status);
-
+    if (substr(php_sapi_name(), 0, 3) == 'cgi')
+    {
+      // fastcgi servers cannot send this status information because it was sent by them already due to the HTT/1.0 line
+      // so we can safely unset them. see ticket #3191
+      unset($this->headers['Status']);
+    }
+
-    if ($this->options['logging'])
-    {