Development

Changeset 19488

You must first sign up to be able to contribute.

Changeset 19488

Show
Ignore:
Timestamp:
06/24/09 09:27:06 (8 months ago)
Author:
fabien
Message:

[lime] changed manual CLI arguments escaping by calls to escapeshellarg()

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • tools/lime/trunk/lib/lime.php

    r18730 r19488  
    591591    sort($this->files); 
    592592 
    593     $this->stats =array( 
     593    $this->stats = array( 
    594594      '_failed_files' => array(), 
    595595      '_failed_tests' => 0, 
     
    600600    { 
    601601      $this->stats[$file] = array( 
    602         'plan'     =>   null, 
     602        'plan'     => null, 
    603603        'nb_tests' => 0, 
    604604        'failed'   => array(), 
     
    611611      ob_start(array($this, 'process_test_output')); 
    612612      // see http://trac.symfony-project.org/ticket/5437 for the explanation on the weird "cd" thing 
    613       passthru(sprintf('cd & "%s" "%s" 2>&1', $this->php_cli, $file), $return); 
     613      passthru(sprintf('cd & %s %s 2>&1', escapeshellarg($this->php_cli), escapeshellarg($file)), $return); 
    614614      ob_end_clean(); 
    615615 
     
    793793      ob_start(); 
    794794      // see http://trac.symfony-project.org/ticket/5437 for the explanation on the weird "cd" thing 
    795       passthru(sprintf('cd & "%s" "%s" 2>&1', $this->harness->php_cli, $tmp_file), $return); 
     795      passthru(sprintf('cd & %s %s 2>&1', escapeshellarg($this->harness->php_cli), escapeshellarg($tmp_file)), $return); 
    796796      $retval = ob_get_clean(); 
    797797 

The Sensio Labs Network

Since 1998, Sensio Labs has been promoting the Open-Source software movement by providing quality web application development, training, consulting.
Sensio Labs also supports several large Open-Source projects.