Changeset 10948

Timestamp:

08/19/08 16:20:41 (11 months ago)

Author:

fabien

Message:

[1.0, 1.1, 1.2] fixed 0000-00-00 dates in mysqli creole driver (closes #2234)

Files:

• branches/1.0/lib/vendor/creole/drivers/mysqli/MySQLiResultSet.php (modified) (1 diff)
• branches/1.1/lib/plugins/sfPropelPlugin/lib/vendor/creole/drivers/mysqli/MySQLiResultSet.php (modified) (1 diff)
• branches/1.2/lib/plugins/sfPropelPlugin/lib/vendor/creole/drivers/mysqli/MySQLiResultSet.php (modified) (1 diff)

branches/1.0/lib/vendor/creole/drivers/mysqli/MySQLiResultSet.php

@@ -140 +140 @@
-        }
-
-
+ || $this->fields[$column] == '0000-00-00 00:00:00'
-            return null;
-        }
-
-        $ts = strtotime($this->fields[$column]);
+
+    /**
+     * @see ResultSetCommon::getDate()
+     */
+    public function getDate($column, $format = '%X')
+    {
+        /* As of PHP 5.2.4, strftime() returns false for '0000-00-00' which
+           is impossible to tell apart from illegal dates. (Pre-PHP 5.2.4
+           even interpreted such dates incorrectly, see 
+           http://bugs.php.net/bug.php?id=41523).
+           We catch this special case and return null as the date here.
+           However, we need to know the exact format the DBMS returns this
+           date, which is why we make this decision here in the specific
+           driver before dispatching to the common implementation. */
+        $idx = (is_int($column) ? $column - 1 : $column);        
+        if (array_key_exists($idx, $this->fields) && $this->fields[$idx] == '0000-00-00') return null;
+        return parent::getDate($column, $format);
+    }
-
-        if ($ts === -1 || $ts === false) { // in PHP 5.1 return value changes to FALSE

branches/1.1/lib/plugins/sfPropelPlugin/lib/vendor/creole/drivers/mysqli/MySQLiResultSet.php

@@ -140 +140 @@
-        }
-
-
+ || $this->fields[$column] == '0000-00-00 00:00:00'
-            return null;
-        }
-
-        $ts = strtotime($this->fields[$column]);
+
+    /**
+     * @see ResultSetCommon::getDate()
+     */
+    public function getDate($column, $format = '%X')
+    {
+        /* As of PHP 5.2.4, strftime() returns false for '0000-00-00' which
+           is impossible to tell apart from illegal dates. (Pre-PHP 5.2.4
+           even interpreted such dates incorrectly, see 
+           http://bugs.php.net/bug.php?id=41523).
+           We catch this special case and return null as the date here.
+           However, we need to know the exact format the DBMS returns this
+           date, which is why we make this decision here in the specific
+           driver before dispatching to the common implementation. */
+        $idx = (is_int($column) ? $column - 1 : $column);        
+        if (array_key_exists($idx, $this->fields) && $this->fields[$idx] == '0000-00-00') return null;
+        return parent::getDate($column, $format);
+    }
-
-        if ($ts === -1 || $ts === false) { // in PHP 5.1 return value changes to FALSE

branches/1.2/lib/plugins/sfPropelPlugin/lib/vendor/creole/drivers/mysqli/MySQLiResultSet.php

@@ -140 +140 @@
-        }
-
-
+ || $this->fields[$column] == '0000-00-00 00:00:00'
-            return null;
-        }
-
-        $ts = strtotime($this->fields[$column]);
+
+    /**
+     * @see ResultSetCommon::getDate()
+     */
+    public function getDate($column, $format = '%X')
+    {
+        /* As of PHP 5.2.4, strftime() returns false for '0000-00-00' which
+           is impossible to tell apart from illegal dates. (Pre-PHP 5.2.4
+           even interpreted such dates incorrectly, see 
+           http://bugs.php.net/bug.php?id=41523).
+           We catch this special case and return null as the date here.
+           However, we need to know the exact format the DBMS returns this
+           date, which is why we make this decision here in the specific
+           driver before dispatching to the common implementation. */
+        $idx = (is_int($column) ? $column - 1 : $column);        
+        if (array_key_exists($idx, $this->fields) && $this->fields[$idx] == '0000-00-00') return null;
+        return parent::getDate($column, $format);
+    }
-
-        if ($ts === -1 || $ts === false) { // in PHP 5.1 return value changes to FALSE