Changeset 10835

Timestamp:

08/13/08 13:58:38 (11 months ago)

Author:

fabien

Message:

[1.2] fixed sfRequest:hasParameter() doesn't allow for NULL values (closes #2118)

Files:

• branches/1.2/UPGRADE_TO_1_2 (modified) (1 diff)
• branches/1.2/lib/util/sfParameterHolder.class.php (modified) (2 diffs)
• branches/1.2/test/unit/util/sfParameterHolderTest.php (modified) (3 diffs)

branches/1.2/UPGRADE_TO_1_2

@@ -172 +172 @@
-
-The `redirect()` method already have this feature.
+
+sfParameterHolder
+-----------------
+
+The `has()` method of `sfParameterHolder` has been changed to be more
+semantically correct.
+
+It now returns `true` even if the value is `null`:
+
+    [php]
+    $ph = new sfParameterHolder();
+    $ph->set('foo', 'bar');
+    $ph->set('bar', null);
+
+    $ph->has('foo') === true;
+    $ph->has('bar') === true; // returns false under symfony 1.0 or 1.1
+
+The `sfParameterHolder::has()` method is used by the `hasParameter()` and
+`hasAttribute()` methods available for a large number of core classes.

branches/1.2/lib/util/sfParameterHolder.class.php

@@ -51 +51 @@
-  public function & get($name, $default = null)
-  {
-isset($this->parameters[$name]
+array_key_exists($name, $this->parameters
-    {
-      $value = & $this->parameters[$name];
@@ -92 +92 @@
-  public function has($name)
-  {
-isset($this->parameters[$name]
+array_key_exists($name, $this->parameters
-    {
-      return true;

branches/1.2/test/unit/util/sfParameterHolderTest.php

@@ -11 +11 @@
-require_once(dirname(__FILE__).'/../../bootstrap/unit.php');
-
-7
+8
-
-// ->clear()
@@ -30 +30 @@
-$t->is($ph->get('bar'), null, '->get() returns null if the key does not exist');
-
-e
+
-$ref = 'foobar';
-
-
+
+
+
-$ref2 &= 'barfoo';
-$t->is($ref2 , $ref, '->get() returns a reference for the given key');
-
-
-$ph = new sfParameterHolder();
@@ -62 +62 @@
-$t->is($ph->has('foo'), true, '->has() returns true if the key exists');
-$t->is($ph->has('bar'), false, '->has() returns false if the key does not exist');
+$ph->set('bar', null);
+$t->is($ph->has('bar'), true, '->has() returns true if the key exist, even if the value is null');
-
-// ->remove()